Move test mock headers into a mock_headers cc_library instead of cc_embed_data#988
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Move test mock headers into a mock_headers cc_library instead of cc_embed_data#988copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…mbed_data To be less dependent on Bazel's cc_embed_data. Otherwise, we need to replicate that in CMake with an `add_custom_command` + python script, or some other method. This is not quite as nice as the original, where you could more easily see the files separately, and potentially switch a nullability_test #include to build with the non-mock header through a cc_library. Otherwise, this is the approach we have in the upstream optional and StatusOr checkers. PiperOrigin-RevId: 912522697
copybara-service
Bot
force-pushed
the
test_912522697
branch
from
72bbadf to
1dfa116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move test mock headers into a mock_headers cc_library instead of cc_embed_data
To be less dependent on Bazel's cc_embed_data. Otherwise, we need to replicate that in CMake with an
add_custom_command+ python script, or some other method.This is not quite as nice as the original, where you could more easily see the files separately, and potentially switch a nullability_test #include to build with the non-mock header through a cc_library.
Otherwise, this is the approach we have in the upstream optional and StatusOr checkers.