feat: AppLocalizations CodeLens preview in Dart code#89
Open
Zensonaton wants to merge 8 commits into
Open
Conversation
I'm not exactly sure if that setting is supposed to be enabled by default.
My "format on save" VSCode setting was removing those semicolons. I've had to enable that in the eslint config so there wouldn't be a lot of unnecessary changes.
…nguage in codelens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
This PR introduces CodeLens support for Dart files that use
AppLocalizationsclass. The feature can be configured via VS Code settings:How it works
The current algorithm scans Dart code for usages of
AppLocalizations. When it infers that a given symbol (e.g., a variable) might be an instance of theAppLocalizationsclass, it issues a Dart LSP request to verify the actual type.Notes
defaultvalue inpackage.json.Future ideas
.arbfile on click.AppLocalizations.helloWorldcould propagate the change to thehelloWorldkey across all.arbfiles..arbentry instead ofAppLocalizations.dart..arbfiles should navigate to the template.arbfile..arbfiles (Shift + F12) should show all Dart code usages.