fix(mcp): guard empty tool parameters in adkToMcpToolType#1340
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_945015920
branch
from
e5dd064 to
4eeea7b
Compare
`adkToMcpToolType` called `Optional.get()` on `parameters()` unguarded, so a present declaration with no parameters (a valid no-argument tool) threw `NoSuchElementException`. Build the MCP tool without an input schema when parameters are absent. Also make the method static so the utility class (`final`, `private` constructor) is actually callable, and add `ConversionUtilsTest`. PiperOrigin-RevId: 945099824
copybara-service
Bot
force-pushed
the
test_945015920
branch
from
4eeea7b to
66fa921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(mcp): guard empty tool parameters in
adkToMcpToolTypeadkToMcpToolTypecalledOptional.get()onparameters()unguarded, so apresent declaration with no parameters (a valid no-argument tool) threw
NoSuchElementException. Build the MCP tool without an input schema whenparameters are absent.
Also make the method static so the utility class (
final,privateconstructor) is actually callable, and add
ConversionUtilsTest.