feat(cli): add bulk extension enable/disable#24661
feat(cli): add bulk extension enable/disable#24661rwmyers wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'extensions select' command to the Gemini CLI, designed to streamline the management of multiple extensions. By providing a bulk selection mechanism, users can now easily switch between different extension configurations without needing to run individual enable/disable commands, improving workflow efficiency for complex development environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the gemini extensions select command, which provides an interactive picker or CLI arguments to enable and disable extensions. The changes include comprehensive documentation updates and unit tests. Feedback suggests improving the implementation by replacing direct process.exit(1) calls with exitCli(1) to ensure proper cleanup, batching MCP server enablement calls outside the loop to optimize I/O, and logging full error objects in catch blocks for better observability.
5417a1c to
ac85d1a
Compare
6f1bf84 to
518089b
Compare
|
I think Not sure adding a new Adding another command adds confusion to users, when to use I could see a world where |
|
Thanks for the feedback. If we call |
Correct, the
Yes my quick thought was you would have @rwmyers I think this work is probably best split into two PRs.
Let me know if that makes sense. 😄 |
|
Sounds great. And to confirm, would we want an I can raise the two PRs in that order. |
|
Relatedly, I was thinking it'd also be super useful to have the same functionality within the CL. I think those are separate CLs as well. If you agree, I'm happy to expand the filed issue to include them (I have a version locally I was playing with, but was waiting to raise that until this was resolved) |
11d589e to
e0f797e
Compare
|
@jackwotherspoon I've amended this PR request to instead expand |
e0f797e to
19070a3
Compare
19070a3 to
a51d3da
Compare
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383). We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'. This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community! |
Summary
I would like to have the ability to select the extensions that are used in one command rather than run numerous commands to enable / disable multiple extensions at once. This is because I frequently have subsets of commands in my user setup that differ (changing as many as 2-3 per time).
I propose updating the
enableanddisablecommands to accept bulk operations (and in a subsequent PR provide a select dialog option):Details
Why is this needed?
This makes it far easier to instantly swap between sets of extensions in the same environment.
For larger code bases, such as large operating system projects (think something like Android), it's easier to have specialized extension packs per area or large subsystem such that you do not context flood the system. While plenty of tools exist to create these extensions, they're a bit of a pain to turn on and off. This command accelerates that process significantly.
Related Issues
#24658
How to Validate
gemini extensionsto see the new command.gemini extensions enable ext-a ext-b(with extensions available to select) to enable multiple extensions.gemini extensions disable ext-a ext-b(with extensions available to select) to disable multiple extensions.enableanddisablecommand with--all, or by naming specific extensions to enable or disable subsets.Pre-Merge Checklist