Add weight_decay_mask to dadapt_adamw, and fix it for prodigy. - #1763
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_973156449
branch
from
August 30, 2026 14:26
46b7373 to
01bd989
Compare
`prodigy`'s `weight_decay_mask` previously required a mask whose tree structure exactly matched the params. Masks that were a prefix of the params tree, or a plain `True`/`False`, raised a pytree structure error even though the docstring documented prefix masks as supported. Both optimizers now route the masking through `optax.add_decayed_weights`. PiperOrigin-RevId: 973454596
copybara-service
Bot
force-pushed
the
test_973156449
branch
from
August 30, 2026 14:45
01bd989 to
d47bc8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
weight_decay_masktodadapt_adamw, and fix it forprodigy.prodigy'sweight_decay_maskpreviously required a mask whose tree structureexactly matched the params. Masks that were a prefix of the params tree, or a
plain
True/False, raised a pytree structure error even though the docstringdocumented prefix masks as supported. Both optimizers now route the masking
through
optax.add_decayed_weights.