Repository navigation
fix: scope pre-commit lint to new issues only - #16
Merged
Merged
Conversation
golangci-lint was running on the entire repo, so pre-existing lint warnings blocked all commits even when the changes were clean. Use --new flag to only report issues in changed code. Also respect --no-verify to match git's own hook skip semantics.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/go-precommit.sh">
<violation number="1" location="scripts/go-precommit.sh:13">
P2: This only recognizes `--no-verify`; include `-n` as well to match Git’s no-verify semantics.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| fi | ||
|
|
||
| # Respect --no-verify (same semantics as git's own hook skip) | ||
| if [[ "$command" =~ --no-verify ]]; then |
There was a problem hiding this comment.
P2: This only recognizes --no-verify; include -n as well to match Git’s no-verify semantics.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/go-precommit.sh, line 13:
<comment>This only recognizes `--no-verify`; include `-n` as well to match Git’s no-verify semantics.</comment>
<file context>
@@ -9,6 +9,11 @@ if [[ ! "$command" =~ ^git\ commit ]]; then
fi
+# Respect --no-verify (same semantics as git's own hook skip)
+if [[ "$command" =~ --no-verify ]]; then
+ exit 0
+fi
</file context>
Suggested change
| if [[ "$command" =~ --no-verify ]]; then | |
| if [[ "$command" =~ (^|[[:space:]])(-n|--no-verify)([[:space:]]|$) ]]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lint run --newinstead ofgolangci-lint runso only issues in changed code are reported--no-verifyflag to match git's own hook skip semanticsWhy
The pre-commit hook runs
golangci-linton the entire repo. Pre-existing lint warnings block all commits even when the changes are clean.Test plan
--no-verify: hook should be skipped