F3DEX3: Added support for advanced lighting#2974
Merged
Merged
Conversation
gonetz
reviewed
Jul 2, 2026
gonetz
left a comment
gonetz
left a comment
Owner
There was a problem hiding this comment.
Large number of changes, but the new code looks clean.
Good work! I have just a few nitpicks.
| gSP.attrOffset = { 0x0100, -0x0100 }; | ||
| gSP.fresnel = {}; | ||
| gSP.alphaCompareCull = {}; | ||
| gSP.lookat.xyz[0][Y] = gSP.lookat.xyz[1][X] = 1.0f; |
| const u32 ofs = _SHIFTR(w0, 8, 8) * 8; | ||
| const u32 len = (1 + _SHIFTR(w0, 19, 5)) * 8; | ||
| for (u32 i = 0; i < len; i += 4) | ||
| for (int i = 0; i < len; i += 4) |
Owner
There was a problem hiding this comment.
why int if len is u32? signed/unsigned mismatch
Contributor
Author
|
Fixed the comments. It is a relatively large change indeed, mostly because ltadv features path in F3DEX3 is intertwined. It is easier to verify that GLideN64 code matched RSP listing without splitting it https://github.com/HackerN64/F3DEX3/blob/main/f3dex3.s#L3505 |
gonetz
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements advanced lighting path in F3DEX3 that allows to render "island test scene" featured in https://www.youtube.com/watch?v=xnAGq_KJbYk using HLE. It also includes most of the "useful" missing features from F3DEX3 that were unimplemented previously.