GLideNUI: hide translations UI when no translations are found#2954
Merged
Conversation
Owner
|
It doesn't look good with Project64: |
Rosalie241
force-pushed
the
glidenui-hidden-translations
branch
from
6168ed8 to
89439f8
Compare
Contributor
Author
|
Should be fixed with the latest changes, thanks for letting me know! |
Owner
Well, it works as before with the current patch of course, because you guarded all the changes by #ifdef M64P_GLIDENUI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes the translations UI hidden when no translations have been found, but keeps the same behavior for any build configuration that isn't
M64P_GLIDENUI.It achieves this behavior by adding a spacer, which is deleted when translations have been found or GLideNUI is built without
M64P_GLIDENUI, else, when no translations have been found, it hides the translations groupbox instead.