Skip to content

Document new denoisers and properties in Using Lightmap global illumination - #8273

Merged
mhilbrunner merged 1 commit into
godotengine:masterfrom
Calinou:using-lightmaps-denoiser
Oct 21, 2023
Merged

Document new denoisers and properties in Using Lightmap global illumination#8273
mhilbrunner merged 1 commit into
godotengine:masterfrom
Calinou:using-lightmaps-denoiser

Conversation

@Calinou

@Calinou Calinou commented Oct 18, 2023

Copy link
Copy Markdown
Member

This also updates List of features to be up-to-date with Godot 4.2's 3D rendering features.

Don't cherry-pick, as this documents features not present in 4.1.

Project used for new images: test_lightmap_denoise.zip

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 18, 2023
@skyace65 skyace65 added this to the 4.2 milestone Oct 19, 2023

@clayjohn clayjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread about/list_of_features.rst Outdated
Comment thread about/list_of_features.rst Outdated
Comment thread about/list_of_features.rst Outdated

@mhilbrunner mhilbrunner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the above

…nation

This also updates List of features to be up-to-date with Godot 4.2's
3D rendering features.
@Calinou
Calinou force-pushed the using-lightmaps-denoiser branch from 7715d08 to 9d313cf Compare October 20, 2023 20:51
@mhilbrunner
mhilbrunner merged commit 548c600 into godotengine:master Oct 21, 2023
@mhilbrunner

Copy link
Copy Markdown
Member

Thank you! Merged.

@Calinou
Calinou deleted the using-lightmaps-denoiser branch October 31, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants