add support for path params in middle of the path#3713
Conversation
|
I have tested these changes locally in a working project and am waiting for a maintainers review before adding specific test cases for this feature. Please let me know if anything else is needed for this PR. Thanks. |
|
Thanks for this PR! This is a great enhancement that brings Goa's path parameter detection in line with Chi router. The examples you mentioned ( To make sure everything works end-to-end, could you add a few tests? I'm thinking That should cover it! The change itself is solid - just want to make sure the integration points work as expected. |
Added support for path params in the middles of the paths as well
Earlier
/user/@{username}didn't registerusernameas a path param.Similarly
/{month}-{day}-{year}from chi's readme examples would only detect{month}as a param and nothing else.After this change, all these path params should be detected and should work .