Repository navigation
Conversation
gitswagata1
left a comment
There was a problem hiding this comment.
Dependency update looks good. Merging.
gitswagata1
left a comment
There was a problem hiding this comment.
Thanks for the work here — the mobile CSS additions look solid. However, the PR scope doesn't match the title:
Title says: "add <=480px responsive block for overflow guards and 44px touch targets"
PR actually contains: 27 changed files, 3256 additions — including PWA support, CI workflow, CONTRIBUTING.md, SETUP-CLOUD.md, a patent disclosure, Supabase schema, new JS modules (adaptive.js, cloud.js, config.js), a full README rewrite, and 3 test suites.
This makes it very hard to review. Please:
-
Split this into separate PRs by concern:
- PR 1: The mobile CSS fix (what the title describes)
- PR 2: PWA support (manifest, service worker, icons)
- PR 3: CI + repo scaffolding (workflows, CONTRIBUTING, issue templates)
- PR 4: Cloud/Supabase features (cloud.js, config.js, schema, SETUP-CLOUD.md)
- PR 5: README rewrite + docs
-
Each PR should be independently reviewable and mergeable. Smaller PRs = faster reviews, cleaner git history, easier rollbacks.
I want to merge the CSS fix — just need it isolated. Thanks!
90c3c4e to
6847b74
Compare
|
Thanks for the clear review — agreed the previous scope was too broad. This branch is now CSS-only: a single append of the Ready for another look when you have a moment. |
|
Reminder: this PR is now CSS-only ( |
|
Thanks for the review — agreed the PR grew far past the title. Plan:
I’ll push a narrowed branch next so review is only the responsive CSS delta. |
Append-only media query for narrow phones. Addresses gitswagata1#4.
|
Reworked this PR to match the title only.
Ready for re-review. |
6847b74 to
3748ed9
Compare
Summary
Addresses #4 — mobile responsiveness for the narrowest screens only.
Scope (as requested): a single append-only change to
css/styles.css.What it does
@media (max-width: 480px)at the end of the stylesheet:Overflow guards
img, svg, video, canvas, table→max-width: 100%.cw-body,.qcode,.table-scroll,.raw-db→max-width: 100%body { overflow-x: hidden }safety net44px touch targets
min-height: 44pxon primary interactive controls (.btn,.mini-btn, nav/auth/handbook controls, etc.).tutor-gearand.ck-boxat least 44×44Layout
.why/.stat-gridsingle column; chips wrapOut of scope
PWA, CI, cloud/Supabase, README, and other files were removed from this PR so it is independently reviewable.
Test plan