Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s runtime/schema dependency to @github/copilot 1.0.12-0 and regenerates the session event models across SDKs to include the new steerable flag on session start metadata.
Changes:
- Bump Node dependency
@github/copilotto^1.0.12-0(and update lockfile). - Regenerate session event types/models to add optional
steerable(Node/TS, Python, Go, .NET). - Ensure (de)serialization includes the new field where applicable (Python).
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/copilot/generated/session_events.py | Adds steerable to the generated Data dataclass and updates from_dict/to_dict to parse/emit it. |
| nodejs/src/generated/session-events.ts | Adds optional steerable to the session start event data typing. |
| nodejs/package.json | Bumps @github/copilot dependency to ^1.0.12-0. |
| nodejs/package-lock.json | Locks resolved @github/copilot and platform packages to 1.0.12-0. |
| go/generated_session_events.go | Adds Steerable field to generated Data struct with JSON tag. |
| dotnet/src/Generated/SessionEvents.cs | Adds Steerable to SessionStartData with JSON attributes. |
Files not reviewed (1)
- nodejs/package-lock.json: Language not supported
SDK Consistency Review ✅I've reviewed this PR for cross-SDK consistency, and all changes maintain excellent consistency across the four SDK implementations. Summary of ChangesThis PR updates the runtime to version 1.0.12-0 and adds support for a new
Consistency Analysis✅ Field naming: All SDKs use the correct casing convention for their language:
✅ Type mapping: All use optional boolean, appropriately expressed in each language:
✅ Documentation: All SDKs include the same documentation: "Whether this session supports remote steering via Mission Control" ✅ Generated code: All changes are in generated files, indicating they came from the same schema update in the ✅ Serialization: All implementations include proper JSON serialization/deserialization for the new field Additional ChangesThe PR also includes a test helper improvement in .NET ( RecommendationThis PR maintains excellent cross-SDK consistency. The new
|
✅ Cross-SDK Consistency ReviewThis PR successfully maintains excellent consistency across all four SDK implementations. The changes fall into two categories: 1. Generated Type Addition:
|
All the test fixes are because there's a breaking runtime change:
ephemeralevents are no longer included in the list of events returned tosession.getMessages. Now, the only way to observe ephemeral events is to have an active event listener at the time they were raised, because the runtime doesn't even track them in memory after that.This is a good change, because it means "resume" behaves the same whether you're resuming a session from disk or that's already active due to a different client. Previously there was an inconsistency whereby
session.getMessageswould return ephemeral events that happened during the current session execution but not ones that happened in earlier executions.