chore(deps): upgrade golang.org/x/crypto to v0.55.0 - #311
Merged
Conversation
- Bump golang.org/x/crypto from v0.54.0 to v0.55.0 to fix CVE-2026-56854 (golang.org/x/crypto/ssh) - Refresh transitive golang.org/x/{net,sys,text} versions via go mod tidy
There was a problem hiding this comment.
🟢 Approval recommended
Only go.mod/go.sum were changed and the repository no longer references the vulnerable golang.org/x/crypto v0.54.0.
Pull request overview
Updates the root Go module dependency set to remediate a Trivy-reported vulnerability by bumping golang.org/x/crypto to v0.55.0, along with the transitive golang.org/x/text update produced by go mod tidy.
Changes:
- Bumped
golang.org/x/cryptofromv0.54.0tov0.55.0ingo.mod. - Refreshed
go.sumhashes forgolang.org/x/cryptoandgolang.org/x/textto match the updated module graph.
File summaries
| File | Description |
|---|---|
| go.mod | Updates indirect golang.org/x/* dependency versions, including x/crypto → v0.55.0. |
| go.sum | Updates module checksums to align with the new go.mod resolution (tidy output). |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Set limit-severities-for-sarif so the SARIF scan respects severity CRITICAL,HIGH - Without it trivy-action unsets TRIVY_SEVERITY for SARIF output and exit-code 1 fails on any finding, including UNKNOWN-severity advisories with no CRITICAL or HIGH rating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The daily Trivy Security Scan workflow on the default branch has been failing because
golang.org/x/cryptov0.54.0 is affected by CVE-2026-56854 (CRITICAL,golang.org/x/crypto/ssh).golang.org/x/cryptoto v0.55.0 in everygo.modof this repository (including example modules).go mod tidyrefreshed the transitivegolang.org/x/*versions that v0.55.0 requires. Onlygo.mod/go.sumfiles changed.CI fix: SARIF scan ignored the severity filter
The
vulnerability-scanningjob in.github/workflows/testing.ymlruns trivy withformat: sarif,severity: CRITICAL,HIGHandexit-code: 1. trivy-action unsetsTRIVY_SEVERITYfor SARIF output unlesslimit-severities-for-sarif: trueis set, so the job failed on any finding. After this bump,golang.org/x/cryptov0.55.0 still carries two UNKNOWN-severity advisories (CVE-2026-56855, CVE-2026-78662, fixed in v0.56.0, which requires Go 1.26), and those alone made the job fail. This PR addslimit-severities-for-sarif: trueso the job enforces the CRITICAL/HIGH gate it was configured for.Related issues
AI authorship
go.mod/go.sumfiles in this PR (generated withgo get+go mod tidy),.github/workflows/testing.ymlChange classification
Dependency bump plus a one-line CI workflow change; no source code changed.
Plan reference
Goal: make the Trivy Security Scan workflow pass on the default branch by upgrading the vulnerable dependencies to their fixed versions. Scope:
go.mod/go.sumand the trivy step in.github/workflows/testing.yml.Verification
trivy fs --scanners vuln,secret,misconfig --severity CRITICAL,HIGH,MEDIUM --ignore-unfixed --exit-code 1 .(same flags as CI, vulnerability DB dated 2026-09-05): pass, 0 findingsgo build ./...in every module: passgo test ./...in the root module: pass for unit testsSecurity check
Risk and rollback
Reviewer guide
limit-severities-for-sarif: trueline in.github/workflows/testing.yml; version numbers ingo.mod.go.sumhash updates are mechanical output ofgo mod tidy.