fix: strip markdown code blocks from Gemini JSON responses#1281
Open
aelhajj wants to merge 1 commit intogetzep:mainfrom
Open
fix: strip markdown code blocks from Gemini JSON responses#1281aelhajj wants to merge 1 commit intogetzep:mainfrom
aelhajj wants to merge 1 commit intogetzep:mainfrom
Conversation
Member
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
danielchalef
added a commit
that referenced
this pull request
Feb 28, 2026
2b3pro
pushed a commit
to 2b3pro/graphiti
that referenced
this pull request
Mar 31, 2026
Port confirmed bug fixes from upstream getzep/graphiti PRs: - PR getzep#1356: Fix label_propagation infinite loop by updating community_map before break check in bounded for-loop - PR getzep#1362/getzep#1291: Strip markdown code fences from OpenAI generic client JSON responses before parsing - PR getzep#1357: CJK character support in MinHash fuzzy dedup - use Unicode \w instead of [a-z0-9], detect CJK for 2-gram shingles vs 3-gram - PR getzep#1332: Guard against null/invalid embeddings in similarity search by adding size() checks to Neo4j and FalkorDB vector queries - PR getzep#1303: Search both edge directions during dedup resolution using bidirectional RELATES_TO match - PR getzep#1330: Fix FalkorDB default_group_id from escaped '\\_' to '_' Not applicable (TS port doesn't have the code): - PR getzep#1281: No Gemini LLM client in TS port - PR getzep#1276: TS resolver uses client-side scoring, not LLM context - PR getzep#1289: TS reranker already returns 0 for empty logprobs - PR getzep#1351: TS episode_mentions_reranker already sorts DESC - PR getzep#1312: TS already validates node labels - PR getzep#1212: TS addTripletFull already checks UUID collision - PRs getzep#1326,1305,1295,1270,1222,1249,1272: FalkorDB RediSearch query building not present in TS port (uses Cypher CONTAINS) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ehfazrezwan
added a commit
to ehfazrezwan/neuralscape
that referenced
this pull request
Apr 2, 2026
feafc42 Bump the uv group across 2 directories with 2 updates (getzep#1363) c4e6923 Upstream Zep internal improvements (getzep#1361) e88c09c @VictorECDSA has signed the CLA in getzep#1356 91fe7e0 @majiayu000 has signed the CLA in getzep#1351 c52786d @dudo has signed the CLA in getzep#1350 d631437 @Ker102 has signed the CLA in getzep#1339 73cff2c @chengjon has signed the CLA in getzep#1340 8c61763 @rhlsthrm has signed the CLA in getzep#1335 e6424ba @pratyush618 has signed the CLA in getzep#1332 6f05647 @bsolomon1124 has signed the CLA in getzep#1330 10d9139 @spencer2211 has signed the CLA in getzep#1326 1ca1468 Add hiring promotion section to README (getzep#1323) 19e44a9 Bump mcp-server to 1.0.2 and require graphiti-core>=0.28.2 (getzep#1317) 77b1609 Bump graphiti-core version to 0.28.2 (getzep#1315) 7d65d5e Harden search filters against Cypher injection (getzep#1312) b10b488 Restore README title and subtitle (getzep#1314) a9065fa Refresh README content and fix image refs (getzep#1313) 5a334ec @lvca has signed the CLA in getzep#1310 45c8040 @jawherkh has signed the CLA in getzep#1309 9eb2c9e @kraft87 has signed the CLA in getzep#1305 334c8fa @adsharma has signed the CLA in getzep#1296 b6f9d87 @StephenBadger has signed the CLA in getzep#1295 4b91076 feat: Add GLiNER2 hybrid LLM client (getzep#1284) db54ce0 chore: update Docker images to graphiti-core 0.28.1 (getzep#1292) edc71e8 @devmao has signed the CLA in getzep#1289 b4ddc55 @carlos-alm has signed the CLA in getzep#1288 aa8e81e @giulio-leone has signed the CLA in getzep#1280 6fdb352 @aelhajj has signed the CLA in getzep#1281 2099603 @avianion has signed the CLA in getzep#1278 9eb59f7 @themavik has signed the CLA in getzep#1214 98f5b5f fix: replace edge name with uuid in debug log (getzep#1261) 510bd50 @hanxiao has signed the CLA in getzep#1257 17a8ea9 @sprotasovitsky has signed the CLA in getzep#1254 9d509a2 @Yifan-233-max has signed the CLA in getzep#1245 ef52a2a chore: regenerate lockfiles to drop diskcache (getzep#1244) 7605303 chore: bump version to 0.28.1 (getzep#1243) bde2f79 fix: replace diskcache with sqlite-based cache to resolve CVE (getzep#1238) git-subtree-dir: graphiti git-subtree-split: feafc42
Author
|
Hi, Can this be reviewed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip markdown code block wrappers (
```json/```) from Gemini responses before JSON parsing, fixing a crash when Gemini wraps JSON in markdown despiteresponse_mime_type=application/jsonbeing set.Type of Change
Objective
N/A (bug fix)
Testing
Tests added in
tests/llm_client/test_gemini_client.pycovering:```jsonblock → parsed correctly```block → parsed correctlyBreaking Changes
Checklist
make lintpasses)Related Issues
Closes #790