chore(e2e-tests): Add a pnpm-lock file to every e2e test folder#20056
Draft
chore(e2e-tests): Add a pnpm-lock file to every e2e test folder#20056
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Nuxt
Other
Bug Fixes 🐛Ci
Node
Other
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JPeer264
force-pushed
the
jp/add-lockfiles
branch
from
e845f6a to
4da1a93
Compare
Comment on lines
+23
to
+25
| } catch { | ||
| // Lock file doesn't exist, that's fine | ||
| } |
There was a problem hiding this comment.
Bug: The code uses the environment variable E2E_IGNORE_LOCKFILE, but the PR description incorrectly refers to it as E2E_FRESH_LOCKFILE.
Severity: LOW
Suggested Fix
Update the pull request description to refer to the correct environment variable, E2E_IGNORE_LOCKFILE, to match the implementation and avoid confusion.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: dev-packages/e2e-tests/lib/copyToTemp.ts#L23-L25
Potential issue: The code checks for the environment variable `E2E_IGNORE_LOCKFILE` to
decide whether to delete a lockfile. However, the pull request description incorrectly
refers to this variable as `E2E_FRESH_LOCKFILE`. This inconsistency between the
implementation and the documentation can lead to confusion and configuration errors, as
a developer might set the wrong variable based on the description, causing the feature
to not work as intended.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Member
Author
|
Back to draft as it isn't as fluent as thought |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a lock file in every e2e test folder. The motivation behind this is that we know exactly which dependency has been updated when our e2e tests are failing, which reduces the amount of debugging transitive dependency updates.
Test run: https://github.com/getsentry/sentry-javascript/actions/runs/23796959377
FAQ
When do they get updated?
Dev: Gitflowand see if the new versions have been resynced todevelop.Who approves?
A PR will be created and enabled as auto-squashmerge, and approved. So nobody needs to do anything, it should be updated automatically (as long as the PR has a green CI)
A PR fails. What to do?
Once a PR fails, e.g. over the weekend, then it could be that nobody merges/fixes it and it stays open for a while. The
peter-evans/create-pull-requestaction actually reuses a PR and it would rebase and force push the changes, so there will always be only one open.I didn't reuse
repo-sync/pull-requestfromgitflow-sync-develop, as it is not maintained and peter-evans is officially at GitHub and still maintains these actions.master/develop- would they benefit from this?No.
masteranddevelopare excluded from this lock file logic so there everything should be as before. It done with theE2E_IGNORE_LOCKFILEenv variable, which has also been added to the documentationOpen issues