Skip to content

chore: Add size limit reports on PRs for Cloudflare#20055

Draft
JPeer264 wants to merge 1 commit intodevelopfrom
jp/size-limit-cloudflare
Draft

chore: Add size limit reports on PRs for Cloudflare#20055
JPeer264 wants to merge 1 commit intodevelopfrom
jp/size-limit-cloudflare

Conversation

@JPeer264
Copy link
Copy Markdown
Member

Cloudflare does have a free tier limit of 3mb: https://developers.cloudflare.com/workers/platform/limits/#worker-size

It would be too bad if we ship something for Cloudflare and by accident ship something which is super costly. I didn't add a limit yet, but we can add one once it makes sense

@JPeer264 JPeer264 self-assigned this Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (core, node) Portable Express integration by isaacs in #19928
  • (deno) Add denoRuntimeMetricsIntegration by chargome in #20023
  • (deps) Bump @xmldom/xmldom from 0.8.3 to 0.8.12 by dependabot in #20066

Bug Fixes 🐛

  • (aws-serverless) Add timeout to _endSpan forceFlush to prevent Lambda hanging by logaretm in #20064
  • (cloudflare) Ensure every request instruments functions by JPeer264 in #20044
  • (gatsby) Fix errorHandler signature to match bundler-plugin-core API by JPeer264 in #20048

Internal Changes 🔧

Core

  • Extract shared endStreamSpan for AI integrations by nicohrubec in #20021
  • Remove provider-specific AI span attributes in favor of gen_ai attributes in sentry conventions by nicohrubec in #20011

Other

  • Add size limit reports on PRs for Cloudflare by JPeer264 in #20055
  • Update validate-pr workflow by stephanie-anderson in #20072
  • Remove unused tsconfig-template folder by mydea in #20067

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,539 - 11,213 -24%
GET With Sentry 1,562 18% 1,972 -21%
GET With Sentry (error only) 6,016 70% 7,611 -21%
POST Baseline 1,161 - 1,281 -9%
POST With Sentry 571 49% 627 -9%
POST With Sentry (error only) 1,009 87% 1,132 -11%
MYSQL Baseline 3,107 - 3,494 -11%
MYSQL With Sentry 358 12% 456 -21%
MYSQL With Sentry (error only) 2,526 81% 2,814 -10%

View base workflow run

@JPeer264 JPeer264 force-pushed the jp/size-limit-cloudflare branch 2 times, most recently from 94fa585 to 6983a44 Compare March 31, 2026 13:47
@JPeer264 JPeer264 force-pushed the jp/size-limit-cloudflare branch from 6983a44 to fada93f Compare April 1, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant