chore: Add THIRD_PARTY_NOTICES.md for vendored third-party code#5186
chore: Add THIRD_PARTY_NOTICES.md for vendored third-party code#5186
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Sentry Build Distribution
|
Sentry Build Distribution
|
romtsn
left a comment
There was a problem hiding this comment.
LGTM, but we also wanted to package this inside the sentry-android/sentry-android-core/sentry .aar/.jar, right? Or you wanna do it in a separate PR?
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
markushi
left a comment
There was a problem hiding this comment.
Done — the THIRD_PARTY_NOTICES.md is now bundled as META-INF/SENTRY_THIRD_PARTY_NOTICES.md in the sentry JAR in this PR.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9ea89e8 | 308.06 ms | 358.16 ms | 50.10 ms |
| b193867 | 319.59 ms | 403.09 ms | 83.50 ms |
| dcc6bbf | 382.58 ms | 462.13 ms | 79.54 ms |
| d501a7e | 307.33 ms | 341.94 ms | 34.61 ms |
| 22f4345 | 325.23 ms | 454.66 ms | 129.43 ms |
| 33a08cc | 267.08 ms | 340.45 ms | 73.37 ms |
| dba088c | 321.78 ms | 364.59 ms | 42.82 ms |
| 092f017 | 353.13 ms | 433.84 ms | 80.71 ms |
| d501a7e | 314.55 ms | 343.34 ms | 28.79 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9ea89e8 | 1.58 MiB | 2.28 MiB | 716.23 KiB |
| b193867 | 1.58 MiB | 2.19 MiB | 620.00 KiB |
| dcc6bbf | 1.58 MiB | 2.12 MiB | 553.10 KiB |
| d501a7e | 0 B | 0 B | 0 B |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 33a08cc | 1.58 MiB | 2.12 MiB | 555.28 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 092f017 | 0 B | 0 B | 0 B |
| d501a7e | 0 B | 0 B | 0 B |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
📜 Description
Adds a
THIRD_PARTY_NOTICES.mdfile documenting all third-party code that has been copied, adapted, or vendored into the repository. This follows the same format used by sentry-cocoa.The file covers 16 third-party sources across the codebase:
Apache 2.0 licensed:
io.sentry.vendor.gson)io.sentry.cache.tape)MIT licensed:
💡 Motivation and Context
Proper attribution of vendored third-party code in a single, discoverable location.
💚 How did you test it?
Documentation-only change, no code modifications.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.