Skip to content

chore: Add THIRD_PARTY_NOTICES.md for vendored third-party code#5186

Merged
markushi merged 7 commits intomainfrom
chore/third-party-notices
Mar 30, 2026
Merged

chore: Add THIRD_PARTY_NOTICES.md for vendored third-party code#5186
markushi merged 7 commits intomainfrom
chore/third-party-notices

Conversation

@markushi
Copy link
Copy Markdown
Member

📜 Description

Adds a THIRD_PARTY_NOTICES.md file documenting all third-party code that has been copied, adapted, or vendored into the repository. This follows the same format used by sentry-cocoa.

The file covers 16 third-party sources across the codebase:

Apache 2.0 licensed:

  • Google GSON — JSON stream reader/writer (io.sentry.vendor.gson)
  • FasterXML Jackson — ISO8601 date utils
  • Android Open Source Project — Base64, thread dump parsing
  • Square Tape — file-based FIFO queue (io.sentry.cache.tape)
  • Square Curtains — Window.Callback handling
  • Apache Commons Collections — CircularFifoQueue, SynchronizedCollection/Queue
  • Matej Tymes JavaFixes — ReusableCountLatch
  • Baomidou Dynamic-Datasource — UUID generation
  • Google Firebase — FirstDrawDoneListener
  • OpenTelemetry — ThreadLocal context storage

MIT licensed:

  • SalomonBrys ANR-WatchDog — ANR detection
  • Breadwallet — root detection
  • KilianB pcg-java — random number generator
  • Jon Chambers — UUID string utils

💡 Motivation and Context

Proper attribution of vendored third-party code in a single, discoverable location.

💚 How did you test it?

Documentation-only change, no code modifications.

📝 Checklist

  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • No breaking change or entry added to the changelog.

🔮 Next steps

None.

markushi and others added 2 commits March 11, 2026 10:48
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Sync file attachments to native by bitsandfoxes in #5211

Internal Changes 🔧

  • Add THIRD_PARTY_NOTICES.md for vendored third-party code by markushi in #5186

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (anr) Profile main thread when ANR and report ANR profiles to Sentry by markushi in #4899

Bug Fixes 🐛

  • Remove the dependency on protobuf-lite for tombstones by supervacuus in #5157

Internal Changes 🔧

  • Add THIRD_PARTY_NOTICES.md for vendored third-party code by markushi in #5186

🤖 This preview updates automatically when you update the PR.

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 11, 2026

Sentry Build Distribution

App Name App ID Version Configuration Install Page
SDK Size io.sentry.tests.size 8.37.1 (1) release Install Build

@markushi markushi marked this pull request as ready for review March 11, 2026 10:06
@sentry
Copy link
Copy Markdown

sentry bot commented Mar 11, 2026

Sentry Build Distribution

App Version Configuration
SDK Size 8.34.1 (1) release

Copy link
Copy Markdown
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we also wanted to package this inside the sentry-android/sentry-android-core/sentry .aar/.jar, right? Or you wanna do it in a separate PR?

markushi and others added 4 commits March 26, 2026 13:12
Copy link
Copy Markdown
Member Author

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — the THIRD_PARTY_NOTICES.md is now bundled as META-INF/SENTRY_THIRD_PARTY_NOTICES.md in the sentry JAR in this PR.

@github-actions
Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 327.29 ms 354.06 ms 26.77 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9ea89e8 308.06 ms 358.16 ms 50.10 ms
b193867 319.59 ms 403.09 ms 83.50 ms
dcc6bbf 382.58 ms 462.13 ms 79.54 ms
d501a7e 307.33 ms 341.94 ms 34.61 ms
22f4345 325.23 ms 454.66 ms 129.43 ms
33a08cc 267.08 ms 340.45 ms 73.37 ms
dba088c 321.78 ms 364.59 ms 42.82 ms
092f017 353.13 ms 433.84 ms 80.71 ms
d501a7e 314.55 ms 343.34 ms 28.79 ms
ce0a49e 532.00 ms 609.96 ms 77.96 ms

App size

Revision Plain With Sentry Diff
9ea89e8 1.58 MiB 2.28 MiB 716.23 KiB
b193867 1.58 MiB 2.19 MiB 620.00 KiB
dcc6bbf 1.58 MiB 2.12 MiB 553.10 KiB
d501a7e 0 B 0 B 0 B
22f4345 1.58 MiB 2.29 MiB 719.83 KiB
33a08cc 1.58 MiB 2.12 MiB 555.28 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB
092f017 0 B 0 B 0 B
d501a7e 0 B 0 B 0 B
ce0a49e 1.58 MiB 2.10 MiB 532.94 KiB

@markushi markushi merged commit 22ff2c7 into main Mar 30, 2026
68 checks passed
@markushi markushi deleted the chore/third-party-notices branch March 30, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants