Skip to content

Upgrade muddy to v3.3.0 and fix sysDownloadError URL-based matching - #49

Merged
gesslar merged 1 commit into
mainfrom
09-01-some_fixes_and_things
Sep 1, 2026
Merged

Upgrade muddy to v3.3.0 and fix sysDownloadError URL-based matching#49
gesslar merged 1 commit into
mainfrom
09-01-some_fixes_and_things

Conversation

@gesslar

@gesslar gesslar commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Upgrades @gesslar/muddy to v3.3.0 and @gesslar/toolkit to v5.9.1, adopting the new muddy CLI invocation style across all npm scripts. The build script is simplified to npx -y muddy, a watch script is added, and the major/minor/patch version bump scripts now pass --package and run npm i afterward.

Fixes a bug in dependency_queue where any sysDownloadError event fired anywhere in the Mudlet profile could incorrectly tear down the dependency queue. Mudlet's sysDownloadError event provides (error, local_file, url) arguments rather than a package name, and it fires for all failed downloads profile-wide — not just those initiated by Glu. The handler now correlates the failing URL against the package currently being waited on before acting. As a fallback for redirected URLs where the host or path may have changed, matching is also attempted by comparing just the file name extracted from each URL.

Two new test cases cover these scenarios: one verifying that an unrelated download failure is ignored and the queue continues normally, and another confirming that a URL-redirected failure is still correctly attributed to the right package. Existing tests are updated to pass the correct sysDownloadError argument signature.

Greptile Summary

The PR upgrades the build dependencies and revises dependency installation to correlate global Mudlet events using a UUID-based local file path.

  • Updates Muddy and Toolkit versions and adopts the new Muddy CLI scripts.
  • Downloads dependencies to uniquely named temporary files before installation.
  • Matches download and installation events against the active local path.
  • Adds regression coverage for unrelated global events and redirected download failures.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (3): Last reviewed commit: "some fixes and things" | Re-trigger Greptile

gesslar commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gesslar
gesslar force-pushed the 09-01-some_fixes_and_things branch 2 times, most recently from 4a8c4fd to c569fe8 Compare September 1, 2026 06:03
Comment thread src/scripts/dependency_queue.lua Outdated
@gesslar
gesslar force-pushed the 09-01-some_fixes_and_things branch from c569fe8 to c697106 Compare September 1, 2026 06:30
Comment thread src/scripts/dependency_queue.lua Outdated
@gesslar
gesslar force-pushed the 09-01-some_fixes_and_things branch from c697106 to 62ff30a Compare September 1, 2026 07:11
@gesslar
gesslar merged commit 9545643 into main Sep 1, 2026
5 checks passed
@gesslar
gesslar deleted the 09-01-some_fixes_and_things branch September 1, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant