Upgrade muddy to v3.3.0 and fix sysDownloadError URL-based matching - #49
Merged
Conversation
gesslar
force-pushed
the
09-01-some_fixes_and_things
branch
2 times, most recently
from
September 1, 2026 06:03
4a8c4fd to
c569fe8
Compare
gesslar
force-pushed
the
09-01-some_fixes_and_things
branch
from
September 1, 2026 06:30
c569fe8 to
c697106
Compare
gesslar
force-pushed
the
09-01-some_fixes_and_things
branch
from
September 1, 2026 07:11
c697106 to
62ff30a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upgrades
@gesslar/muddyto v3.3.0 and@gesslar/toolkitto v5.9.1, adopting the newmuddyCLI invocation style across all npm scripts. Thebuildscript is simplified tonpx -y muddy, awatchscript is added, and themajor/minor/patchversion bump scripts now pass--packageand runnpm iafterward.Fixes a bug in
dependency_queuewhere anysysDownloadErrorevent fired anywhere in the Mudlet profile could incorrectly tear down the dependency queue. Mudlet'ssysDownloadErrorevent provides(error, local_file, url)arguments rather than a package name, and it fires for all failed downloads profile-wide — not just those initiated by Glu. The handler now correlates the failing URL against the package currently being waited on before acting. As a fallback for redirected URLs where the host or path may have changed, matching is also attempted by comparing just the file name extracted from each URL.Two new test cases cover these scenarios: one verifying that an unrelated download failure is ignored and the queue continues normally, and another confirming that a URL-redirected failure is still correctly attributed to the right package. Existing tests are updated to pass the correct
sysDownloadErrorargument signature.Greptile Summary
The PR upgrades the build dependencies and revises dependency installation to correlate global Mudlet events using a UUID-based local file path.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Reviews (3): Last reviewed commit: "some fixes and things" | Re-trigger Greptile