Skip to content

[WIP] Boundary composition plugin based on mesh deformation output - #7225

Open
anne-glerum wants to merge 12 commits into
geodynamics:mainfrom
anne-glerum:mesh_def_boundary_composition
Open

[WIP] Boundary composition plugin based on mesh deformation output#7225
anne-glerum wants to merge 12 commits into
geodynamics:mainfrom
anne-glerum:mesh_def_boundary_composition

Conversation

@anne-glerum

@anne-glerum anne-glerum commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Uncleaned MWE to discuss with @tjhei only for now.

For all pull requests:

If yes, please describe your usage of AI models in the creation of this pull request

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Comment thread include/aspect/mesh_deformation/interface.h Outdated

@tjhei tjhei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good otherwise!

Comment thread include/aspect/boundary_composition/mesh_deformation.h Outdated
Comment thread include/aspect/mesh_deformation/fastscape.h Outdated

@tjhei tjhei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

::::{dropdown} __Parameter:__ {ref}`Data file name<parameters:Initial_20composition_20model/Ascii_20data_20model/Data_20file_20name>`
:name: parameters:Initial_20composition_20model/Ascii_20data_20model/Data_20file_20name
**Default value:** initial_composition_top_mantle_box_3d.txt
**Default value:** box_2d.txt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this come from?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did make parameters, that must have updated it. box_2d.txt seems like the right value:


make parameters still returns that value. But the tester isn't happy about it.

initial_composition_top_mantle_box_3D.txt is the default file for AsciiDataLayered:

"initial_composition_top_mantle_box_3d.txt");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsciiDataLayered is not in the sphinx file. Maybe they overwrite somehow?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably found the reason, I'll fix it in a separate PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #7260.

Comment thread include/aspect/mesh_deformation/diffusion.h Outdated
Comment thread source/mesh_deformation/interface.cc Outdated
@tjhei

tjhei commented Aug 11, 2026

Copy link
Copy Markdown
Member

Hey @anne-glerum , do you need help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants