[WIP] Boundary composition plugin based on mesh deformation output - #7225
Open
anne-glerum wants to merge 12 commits into
Open
[WIP] Boundary composition plugin based on mesh deformation output#7225anne-glerum wants to merge 12 commits into
anne-glerum wants to merge 12 commits into
Conversation
tjhei
reviewed
Jul 30, 2026
tjhei
reviewed
Jul 30, 2026
tjhei
approved these changes
Jul 30, 2026
| ::::{dropdown} __Parameter:__ {ref}`Data file name<parameters:Initial_20composition_20model/Ascii_20data_20model/Data_20file_20name>` | ||
| :name: parameters:Initial_20composition_20model/Ascii_20data_20model/Data_20file_20name | ||
| **Default value:** initial_composition_top_mantle_box_3d.txt | ||
| **Default value:** box_2d.txt |
Contributor
Author
There was a problem hiding this comment.
I did make parameters, that must have updated it. box_2d.txt seems like the right value:
make parameters still returns that value. But the tester isn't happy about it.
initial_composition_top_mantle_box_3D.txt is the default file for AsciiDataLayered:
Contributor
Author
There was a problem hiding this comment.
AsciiDataLayered is not in the sphinx file. Maybe they overwrite somehow?
Contributor
Author
There was a problem hiding this comment.
Probably found the reason, I'll fix it in a separate PR.
Member
|
Hey @anne-glerum , do you need help with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncleaned MWE to discuss with @tjhei only for now.
For all pull requests:
If yes, please describe your usage of AI models in the creation of this pull request
For new features/models or changes of existing features: