fix: trailing space incorrectly added to some directories

[dberlin]

There is code that purports to avoid adding trailing spaces to directory expansions, here:

fifc/functions/_fifc.fish

Line 69 in e953fcd

if test (count $result) -eq 1; and not test -d (string unescape -- $result[1])

This works for some directories, but if you do something like cd ~/foo<tab> where foo is the unique prefix of a directory in your homedir, it will add a space.

Presumably because it is not tilde-expanding the result when it's a string. test -d does not tilde expand strings. In fact, i can't find any function that does - path resolve will not do it, etc.

It looks like fish added a way to expand tokens in master, which will be nice someday when everyone is on fish 3.8.
See the end of fish-shell/fish-shell#5793

Otherwise, the only way to make this work seems to be
eval "echo" <string>

IE
replacing
set -a result (string join -- "" "~" (string sub --start 2 -- $token | string escape))
with
set -a result (eval 'echo' (string join -- "" "~" (string sub --start 2 -- $token | string escape)))

makes it all work
this seems super ugly but even the bug report above mentions it as the way to get everything expanded.
Happy to prepare a patch.

[yannk]

I asked Claude to fix this for me and it came up with this instead:

  3 --- a/.config/fish/functions/_fifc.fish
  4 +++ b/.config/fish/functions/_fifc.fish
  5 @@ -65,10 +65,8 @@
  6      # Add space trailing space only if:
  7      # - there is no trailing space already present
  8      # - Result is not a directory
  9 -    # We need to unescape $result for directory test as we escaped it before.
 10 -    # Also expand leading ~/ manually since test -d does not tilde-expand strings.
 11 -    set -l _fifc_test_path (string replace --regex '^~/' "$HOME/" -- (string unescape -- $result[1]))
 12 -    if test (count $result) -eq 1; and not test -d $_fifc_test_path
 13 +    # We need to unescape $result for directory test as we escaped it before
 14 +    if test (count $result) -eq 1; and not test -d (string unescape -- $result[1])
 15          set -l buffer (string split -- "$fifc_commandline" (commandline -b))
 16          if not string match -- ' *' "$buffer[2]"
 17              set -a result ''