Skip to content

Lyrics with unicode, handling meta events and stopping #22

Description

@manojmo

hi,
firstly, thanks for this nice framework.

i wanted to also display lyrics in devnagari(indian script) and found that currently it won't work as it is,
due to the x-user-defined charset. so i had to add some conversion code. i also tried another approach with a different version of loadRemote() in index.html, using the arrayBuffer type. then i had to change stream.js accordingly, which i have saved as stream1.js. i think this is a better approach, as to-from encoding conversions are reduced. the "b102_Bhairavi_*.mid file i have used is the test-file for unicode lyrics.
Of course we also need to read and propagate lyrics events in replayer, and i have done it using the handleMidiMetaEvent().

i have also added a stop button by calling the audioplayer.stop().it works, but i wonder if some other clean-up needs to be done.

have attached my change files to this issue.

regards,
manoj

jasmid_fix.zip

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions