fix(gbrain-lib): pin LC_ALL=C in varname validator (macOS locale guard)

[andrey-esipov]

Summary

• _gstack_gbrain_validate_varname in bin/gstack-gbrain-lib.sh uses case "$name" in [A-Z_][A-Z0-9_]*) to validate that callers pass an ASCII-uppercase identifier
• On macOS, the default user locale (en_US.UTF-8) makes bash case glob brackets locale-collation-sensitive, so [A-Z] matches lowercase letters too — lower-case passes the check
• The function then trips printf -v "$varname" and export "$varname" with not a valid identifier errors that surface as confusing mid-prompt failures (instead of the clean invalid var name '…' (must match [A-Z_][A-Z0-9_]*) message the validator was supposed to emit)
• Fix: pin LC_ALL=C for the duration of the function so the bracket expression has ASCII-only semantics on both macOS and Linux, matching the documented [A-Z_][A-Z0-9_]* contract

The existing test test/gbrain-lib-verify.test.ts → 'rejects invalid var names (must match [A-Z_][A-Z0-9_]*)' already covers the macOS repro shape. It passes silently on Linux CI (whose default is typically C / POSIX) and fails on macOS dev boxes — so this PR is the source-side fix that makes that test pass on every platform without changing the test.

Repro (macOS, default user locale)

$ bash -c 'name="lower-case"; case "$name" in [A-Z_][A-Z0-9_]*) echo "MATCHED";; *) echo "NO MATCH";; esac'
MATCHED                                # ← bug

$ LC_ALL=C bash -c 'name="lower-case"; case "$name" in [A-Z_][A-Z0-9_]*) echo "MATCHED";; *) echo "NO MATCH";; esac'
NO MATCH                               # ← desired

Before the fix:

$ . bin/gstack-gbrain-lib.sh && read_secret_to_env "lower-case" "Prompt: " <<< "anything"
Prompt: bin/gstack-gbrain-lib.sh: line 89: printf: `lower-case': not a valid identifier
bin/gstack-gbrain-lib.sh: line 91: export: `lower-case': not a valid identifier

After the fix the validator rejects on the first line with the documented error message before either printf -v or export runs.

Test plan

• bun test test/gbrain-lib-verify.test.ts passes (22/22) on macOS Sonoma + bash 3.2 (system) and bash 5.x (homebrew). Linux CI was already green.
• Manual: _gstack_gbrain_validate_varname lower-case; echo $? returns 2; _gstack_gbrain_validate_varname FOO_BAR; echo $? returns 0.
• No other call sites of the validator changed.
• Reviewers may want to confirm no other case glob in bin/ is similarly locale-sensitive (I grep'd; the rest of the script uses literal strings or =~ regex, which also honors LC_COLLATE in bash 4+ but isn't used for [A-Z]-style ranges in this file).

🤖 Generated with Claude Code

[andrey-esipov]

Self-review caught a side-effect bug in v1 and force-pushed b56666f. The original commit had a bare LC_ALL=C inside the validator — without local, it leaks into the calling shell because gstack-gbrain-lib.sh is documented as a sourced helper.

Repro for the leak (before the fix):

$ bash -c '. bin/gstack-gbrain-lib.sh; LC_ALL=en_US.UTF-8; _gstack_gbrain_validate_varname FOO; echo "LC_ALL after: $LC_ALL"'
LC_ALL after: C    # ← downstream sort/tr/grep -P now silently change behavior

After the fix (local LC_ALL=C):

LC_ALL after: en_US.UTF-8    # ← caller preserved

The case statement still gets ASCII-only bracket semantics inside the function, so lower-case is still correctly rejected. 22/22 tests in gbrain-lib-verify.test.ts still pass.

Commit message and code comment updated to call out both the locale pin and the local requirement so future contributors don't drop the local keyword by accident.

[garrytan]

Your fix landed in v1.43.2.0 (the CHANGELOG credits you by name via PR #1606). Closing this PR — the work shipped through a parallel route. Thanks for the contribution, @andrey-esipov!