Fix unusable textboxes in narrow screens#167
Open
kisaragi-hiu wants to merge 1 commit into
Open
Conversation
This just piles on a bunch of rules (which also need to be !important to override inline styles) to make textboxes and inputs usable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is the best glossary editor I've ever seen, thank you; sorry for suddenly popping up 3 PRs)
On small screens, many text inputs in Terminologue become unusable as they are on the same line as their labels, and their labels assume there is enough space to use a fixed 200-something px width, resulting in the label taking up a bunch of space for nothing while the input is squished to the side.
While IMO ideally this would be fixed with a refactoring away from inline styles towards styles that are easier to override in a media rule, here I've simply tried to apply a few more rules (with liberal use of
!importantto override inline styles where necessary) so that on narrow screens these inputs are displayed on a second line.