Fix GCP Batch co-execution deadlocks#466
Merged
mvdbeek merged 4 commits intoJul 3, 2026
Merged
Conversation
Member
d2487a8 to
bcd073e
Compare
mvdbeek
approved these changes
Jun 19, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #465.
This PR ensures the tool and sidecar runnables are executed in the correct order and don't deadlock.
This PR also:
Galaxy's path rewriting causes tools to write outputs into
working/rather thanoutputs/, but__collect_outputs()only checked the outputs directory, so those files were skipped. Also relaxes the dynamic collection pattern fromdataset_\d+\.dattodataset_[\w-]+\.datso UUID-named datasets (e.g.dataset_b0e57817-….dat) match.FileNotFoundErroris deliberately excluded.docker_extra_volumesto the Batch containersComma-separated Docker
-v-style volumes (used to bind-mount CVMFS paths such as/cvmfs/data.galaxyproject.org) are now applied to both the sidecar and tool runnablecontainers, so tools that depend on CVMFS reference data work.