Skip to content

๐Ÿ“ฑ ์ž‘์€ ํ™”๋ฉด ๋ ˆ์ด์•„์›ƒ ๊ฐœ์„  (#235)#240

Open
gaeng2y wants to merge 1 commit into
developfrom
feature/#235-responsive-layout
Open

๐Ÿ“ฑ ์ž‘์€ ํ™”๋ฉด ๋ ˆ์ด์•„์›ƒ ๊ฐœ์„  (#235)#240
gaeng2y wants to merge 1 commit into
developfrom
feature/#235-responsive-layout

Conversation

@gaeng2y

@gaeng2y gaeng2y commented May 28, 2026

Copy link
Copy Markdown
Owner

๐Ÿ“ Summary

๋ฉ”์ธ ๊ธฐ๋ก ํ™”๋ฉด๊ณผ ์˜จ๋ณด๋”ฉ ํ™”๋ฉด์ด ์ž‘์€ ํ™”๋ฉด ๋ฐ Accessibility Dynamic Type์—์„œ๋„ CTA์™€ ๋ณธ๋ฌธ์— ์ ‘๊ทผ ๊ฐ€๋Šฅํ•˜๋„๋ก ๋ ˆ์ด์•„์›ƒ์„ ์กฐ์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Type of Change

  • โœจ New feature (์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€)
  • ๐Ÿ› Bug fix (๋ฒ„๊ทธ ์ˆ˜์ •)
  • ๐Ÿ”ง Configuration (์„ค์ • ๋ณ€๊ฒฝ)
  • โ™ป๏ธ Refactoring (์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง)
  • ๐Ÿ“ Documentation (๋ฌธ์„œ ์ˆ˜์ •)
  • ๐ŸŽจ UI/UX (๋””์ž์ธ ๋ณ€๊ฒฝ)
  • โšก Performance (์„ฑ๋Šฅ ๊ฐœ์„ )
  • ๐Ÿ›ก๏ธ Security (๋ณด์•ˆ ๊ฐ•ํ™”)
  • ๐Ÿงช Test (ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€/์ˆ˜์ •)
  • ๐Ÿ”จ Build (๋นŒ๋“œ ์‹œ์Šคํ…œ ์ˆ˜์ •)

๐Ÿ”— Related Issues

๐Ÿ“‹ Changes Made

Added

  • ๋ฉ”์ธ ๊ธฐ๋ก ํ™”๋ฉด ์ „์ฒด ์ฝ˜ํ…์ธ ์— ํฌ๊ธฐ ๊ธฐ๋ฐ˜ ScrollView๋ฅผ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์˜จ๋ณด๋”ฉ ๊ฐ ํŽ˜์ด์ง€ ๋ณธ๋ฌธ์— ScrollView๋ฅผ ์ ์šฉํ•ด footer CTA ์ ‘๊ทผ์„ฑ์„ ์œ ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ž‘์€ ํ™”๋ฉด๊ณผ Accessibility Dynamic Type ๋Œ€์‘ ์ •์ฑ…์„ ์ œํ’ˆ ์ŠคํŽ™ ๋ฌธ์„œ์— ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changed

  • ๋ฉ”์ธ ๊ธฐ๋ก ํ™”๋ฉด์˜ ๋ฌผ๋ฐฉ์šธ ์˜์—ญ ๋†’์ด๋ฅผ ํ™”๋ฉด ํฌ๊ธฐ์™€ Dynamic Type์— ๋”ฐ๋ผ ์กฐ์ •ํ•˜๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํฐ ๊ธ€์ž ํฌ๊ธฐ์—์„œ๋Š” ์ˆ˜๋ถ„ ์š”์•ฝ, ํ”„๋ฆฌ์…‹ ๋ฒ„ํŠผ, ์ตœ๊ทผ ๊ธฐ๋ก ๋˜๋Œ๋ฆฌ๊ธฐ ์•ก์…˜์ด ์„ธ๋กœ ๋ฐฐ์น˜๋˜๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์˜จ๋ณด๋”ฉ ํŒจ๋„ ๋†’์ด์™€ ํƒ€์ดํ‹€ ํฌ๊ธฐ๋ฅผ compact layout ๊ธฐ์ค€์œผ๋กœ ์กฐ์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

Fixed

  • ์ž‘์€ ํ™”๋ฉด ๋˜๋Š” Accessibility Dynamic Type์—์„œ ๋ฉ”์ธ ๊ธฐ๋ก CTA, ํ”„๋ฆฌ์…‹, ์˜จ๋ณด๋”ฉ ์ด์ „/๋‹ค์Œ CTA๊ฐ€ ํ™”๋ฉด ๋ฐ–์œผ๋กœ ๋ฐ€๋ฆด ์ˆ˜ ์žˆ๋Š” ๋ ˆ์ด์•„์›ƒ ์œ„ํ—˜์„ ์ค„์˜€์Šต๋‹ˆ๋‹ค.

Removed

  • ๊ณ ์ • VStack ๊ธฐ๋ฐ˜์œผ๋กœ ํ™”๋ฉด ๋†’์ด์— ๋งž์ถ”๋˜ ๋ฉ”์ธ/์˜จ๋ณด๋”ฉ ๋ ˆ์ด์•„์›ƒ ์˜์กด์„ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ” Technical Details

  • DrinkWaterView๋Š” ์™ธ๋ถ€ GeometryReader๋กœ ๊ฐ€์šฉ ๋†’์ด๋ฅผ ์ฝ๊ณ , ์ฝ˜ํ…์ธ ๋ฅผ ScrollView ์•ˆ์— ๋ฐฐ์น˜ํ•ฉ๋‹ˆ๋‹ค.
  • waterDropAreaHeight(for:)๋กœ ๊ธฐ๋ณธ/compact/accessibility ๋†’์ด ๋ฒ”์œ„๋ฅผ ๋ถ„๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.
  • OnboardingView๋Š” TabView ํŽ˜์ด์ง€๋งˆ๋‹ค ์Šคํฌ๋กค ๊ฐ€๋Šฅํ•œ ๋ณธ๋ฌธ์„ ๋‘๊ณ  footer๋Š” ํ•˜๋‹จ์— ์œ ์ง€ํ•ฉ๋‹ˆ๋‹ค.
  • Reduce Motion๊ณผ ๊ธฐ์กด ๋ฌผ๋ฐฉ์šธ ์• ๋‹ˆ๋ฉ”์ด์…˜ ์‹คํ–‰ ์กฐ๊ฑด์€ ์œ ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Screenshots / Videos

Before

์ฒจ๋ถ€ ์—†์Œ

After

์ฒจ๋ถ€ ์—†์Œ

โœ… Testing

Test Plan

  • ์•ฑ ๋นŒ๋“œ ์„ฑ๊ณต
  • Debug ๋ชจ๋“œ ์ •์ƒ ์ž‘๋™
  • Release ๋ชจ๋“œ ์ •์ƒ ์ž‘๋™
  • ๊ธฐ์กด ๊ธฐ๋Šฅ ์˜ํ–ฅ ์—†์Œ
  • Widget Extension ์ •์ƒ ์ž‘๋™ (ํ•ด๋‹น์‹œ)

Test Environment

  • iOS Version: iOS Simulator 26.5
  • Device: iPhone 17 Pro Simulator (125B9A31-6A4A-466D-A8AB-410730B22446)
  • Xcode Version: Xcode 26.5 (17F42)

Test Results

  • git diff --check ํ†ต๊ณผ
  • make lint ํ†ต๊ณผ
  • make arch-check ํ†ต๊ณผ
  • xcodebuild test -workspace Mulimi.xcworkspace -scheme PresentationLayer -destination platform=iOS Simulator,id=125B9A31-6A4A-466D-A8AB-410730B22446 -sdk iphonesimulator -derivedDataPath /tmp/MulimiIssue235PresentationTests ํ†ต๊ณผ (88 tests)
  • xcodebuild build -workspace Mulimi.xcworkspace -scheme Mulimi -destination generic/platform=iOS CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO -derivedDataPath /tmp/MulimiIssue235AppBuild ํ†ต๊ณผ

๐Ÿšจ Breaking Changes

  • Yes (์•„๋ž˜์— ์„ค๋ช…)
  • No

๐Ÿ“Œ Additional Notes

  • iPhone 16e iOS 26.3 ๋Ÿฐํƒ€์ž„์—์„œ ์ถ”๊ฐ€ ํ™”๋ฉด ํ™•์ธ์„ ์‹œ๋„ํ–ˆ์ง€๋งŒ Firebase/GoogleUtilities ๋Ÿฐํƒ€์ž„ ์˜ˆ์™ธ๋กœ ์•ฑ์ด ์ฆ‰์‹œ ์ข…๋ฃŒ๋˜์–ด ์Šคํฌ๋ฆฐ์ƒท์€ ์ฒจ๋ถ€ํ•˜์ง€ ๋ชปํ–ˆ์Šต๋‹ˆ๋‹ค. ํ•ด๋‹น ์˜ˆ์™ธ๋Š” ์ด๋ฒˆ ๋ ˆ์ด์•„์›ƒ ๋ณ€๊ฒฝ ์ปดํŒŒ์ผ ๊ฒฝ๋กœ์™€ ๋ฌด๊ด€ํ•ฉ๋‹ˆ๋‹ค.
  • ์•ฑ ๋นŒ๋“œ ์ค‘ AppIntents SSU artifact archive ๋กœ๊ทธ๊ฐ€ ์ถœ๋ ฅ๋์ง€๋งŒ ์ตœ์ข… ๊ฒฐ๊ณผ๋Š” BUILD SUCCEEDED์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ‘€ Review Checklist

  • ์ฝ”๋“œ๊ฐ€ ํ”„๋กœ์ ํŠธ์˜ ์ฝ”๋”ฉ ์ปจ๋ฒค์…˜์„ ๋”ฐ๋ฅด๊ณ  ์žˆ๋‚˜์š”?
  • ์ƒˆ๋กœ์šด ์˜์กด์„ฑ์ด ํ•„์š”ํ•œ๊ฐ€์š”? ์•„๋‹ˆ์š”
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ๊ฐ€ ํ•„์š”ํ•œ๊ฐ€์š”? ๋ฐ˜์˜ ์™„๋ฃŒ
  • ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜์ด ํ•„์š”ํ•œ๊ฐ€์š”? ์•„๋‹ˆ์š”
  • ํ™˜๊ฒฝ ์„ค์ • ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ๊ฐ€์š”? ์•„๋‹ˆ์š”

๋ฉ”์ธ๊ณผ ์˜จ๋ณด๋”ฉ Dynamic Type ๋Œ€์‘
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant