Fix critical bugs and expand test coverage - #84
Open
thejedi433 wants to merge 1 commit into
Open
Conversation
thejedi433
changed the title
Owner
|
@ thejedi433 I will review the changes but can you please remove the AI-generated markdown files that were added? |
thejedi433
pushed a commit
to thejedi433/vault
that referenced
this pull request
Aug 17, 2026
Per maintainer request in PR gabfl#84 feedback.
Author
|
Thanks for the feedback! I've cleaned up the PR and removed the unnecessary files. The changes now focus only on the bug fixes and test improvements. Let me know if you need any other changes! |
thejedi433
force-pushed
the
main
branch
2 times, most recently
from
August 18, 2026 12:54
ab6825b to
ea9ccdb
Compare
thejedi433
changed the title
Bug fixes: - Fix Config instance isolation (prevent shared state between instances) - Enable change_key feature (was marked as not implemented) - Enhance padding validation in Encryption.decrypt() Test improvements: - Add 29 new unit tests - Update test_initialize_3 to mock change_key.rekey() - All 287 tests passing Verified on Python 3.11 with uv virtual environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 critical bugs and expands the test suite with 29 new unit tests.
Bug Fixes
Test Coverage
Added 29 new tests:
All 287 tests pass on Python 3.11.