Skip to content

prevent out-of-bounds slice in tag name on unterminated interpolation - #256

Merged
g-plane merged 2 commits into
g-plane:mainfrom
UnknownPlatypus:fix-tag-name-oob
Sep 1, 2026
Merged

prevent out-of-bounds slice in tag name on unterminated interpolation#256
g-plane merged 2 commits into
g-plane:mainfrom
UnknownPlatypus:fix-tag-name-oob

Conversation

@UnknownPlatypus

@UnknownPlatypus UnknownPlatypus commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

It used to read out of bound for the cases in unterminated_interpolation_in_tag_is_rejected where the document stop before the hardcoded {{ }} offset

  • The pull request description was written manually by me and was not generated by an AI tool or agent.
  • I have read and understood the relevant parts of the existing codebase before making these changes.
  • I have carefully reviewed and understood all code changes, and ensured that they match the style, architecture, and conventions of the existing codebase.
  • I understand that pull requests containing blindly generated or unreviewed AI-generated code may be closed without review.

@netlify

netlify Bot commented Aug 23, 2026

Copy link
Copy Markdown

Deploy Preview for markup-fmt ready!

Name Link
🔨 Latest commit 8df6e85
🔍 Latest deploy log https://app.netlify.com/projects/markup-fmt/deploys/6a962bf198cabc00089d9870
😎 Deploy Preview https://deploy-preview-256--markup-fmt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@UnknownPlatypus UnknownPlatypus changed the title fix: prevent out-of-bounds slice in tag name on unterminated interpolation prevent out-of-bounds slice in tag name on unterminated interpolation Aug 23, 2026
Comment thread markup_fmt/src/lib.rs Outdated
@g-plane
g-plane merged commit e8b0249 into g-plane:main Sep 1, 2026
5 checks passed
@UnknownPlatypus
UnknownPlatypus deleted the fix-tag-name-oob branch September 1, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants