fix(#667): add regex pattern decomposition guidance to review sub-agents - #668
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#667): add regex pattern decomposition guidance to review sub-agents#668fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Both the correctness and challenger sub-agents lacked domain-specific guidance for verifying regex patterns in findings. This caused false positives where character class boundaries were misread as adjacent literals (e.g., `[Cc]lose` read as having a double 'c'). Add a "Regex pattern verification" section to correctness.md requiring element-by-element pattern decomposition before reporting regex-based findings. Add "Regex pattern misread" to challenger.md's false-positive checklist with instructions to independently decompose cited patterns before confirming findings. Closes #667
|
🤖 Finished Review · ✅ Success · Started 8:20 AM UTC · Completed 8:29 AM UTC |
ReviewFindingsMedium
Labels: PR modifies review sub-agent definitions (skills/pr-review/sub-agents/) |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/pr-review/sub-agents/correctness.mdrequiring element-by-element regex decomposition (character classes, quantifiers, anchors, alternations, escape sequences, literals) before reporting findings that assert a regex pattern is incorrectskills/pr-review/sub-agents/challenger.mdwith instructions to independently decompose any cited regex pattern before confirming or removing a findingContext
On PR #595, both the correctness and challenger sub-agents misread
[Cc]lose[sd]?as containing a double 'c', confusing the[Cc]character class boundary with the adjacentloseliteral. Neither sub-agent definition had regex-specific guidance to prevent this class of false positive.Testing
post-triage-test.shunrelated to this change)Closes #667
Post-script verification
agent/667-regex-decomposition-guidance)6c81c8c420ac5a8e30e09639f4b7f869396ece92..HEAD)