Repository navigation
Conversation
React 19 treats `inert` as a boolean prop, so `inert: ''` is read as false: it logs a dev warning and the offscreen probe is left focusable. Preact accepts `true` as well, so this is safe for every connector. Fixes fullcalendar#8114 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
hi @ovelilla , see my comment here #8114 (comment) about this being implemented in v7.1.1 Btw, in order to get this to work for React 18 and 17, which we still support, we needed to use a slightly different technique. So closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8114
The offscreen
MoreLinkTriggerprobe inDayGridRowsandTimeGridAllDayLaneis rendered withinert: ''. Preact sets the attribute for an empty string, but React 19 treatsinertas a boolean prop where''meansfalse, so with@fullcalendar/react:inert" in development.aria-hiddenand its link can receive keyboard focus.This changes both places to
inert: true, which Preact also renders as theinertattribute, so it is safe for every connector. We have been running this exact change viapatch-packageon the compiled@fullcalendar/react7.1.0 chunks, and it resolves both symptoms.🤖 Generated with Claude Code