Repository navigation
install: stop announcing shim installs/refreshes on every run - #1816
Merged
Merged
Conversation
install.sh and --update printed a line every time it placed or refreshed the Antigravity TUI shim (~/.agents/bin/agy-tui) or the Codex monitor shim (~/.agents/bin/codex), even though nothing about the run was unexpected. An install that writes into ~/.agents/bin and announces it on every single run looks like something unusual is being done to the machine, when it is just routine upkeep of a shim the install already owns. Drop those 'installed'/'refreshed' lines for both shims, in both the fresh-install and --update paths. Lines that report a failure or ask the user to act (a shim left untouched because another install owns it, a refusal, etc.) are unchanged.
…1815) Follow-up to the previous commit: install_antigravity_tui_shim still printed a line when it left an existing ~/.agents/bin/agy-tui alone, either because the file wasn't agmsg's or because it belonged to a different install. Drop those too, keeping the same return-0 behavior with no output. The Codex shim's own refusal (on stderr, from codex-shim-install.sh) is unrelated and unchanged. Also drops the now-unused AGMSG_CODEX_SHIM_REFRESHED tracking left over from the lines removed in the previous commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shandinstall.sh --updaterun printed a line for every outcome of placing, refreshing, or leaving alone the Antigravity TUI shim (~/.agents/bin/agy-tui) or the Codex monitor shim (~/.agents/bin/codex), even when nothing unexpected happened. Writing into~/.agents/binand announcing it every single run looks like something unusual is being done to the machine, when it's routine upkeep of a shim the install already owns.+ installed/+ refreshed/~ left ... untouchedlines for both shims, in both the fresh-install and--updatepaths.codex-shim-install.sh) — and whether/where either shim is placed.Test plan
--update, a foreign file left in place, or a shim already owned by a different install — while the underlying placement/refresh/leave-alone behavior is unchanged; verified red against the pre-fix output and green afterrefreshed Codex monitor shimline now assert its absence insteadtests/test_install.batssuite passes.github/scripts/check-enforced-assertions.sh/check-errexit-status-reads.sh/check-unguarded-env-reads.shall at baseline