Skip to content

Don't allow signing up to intoduction event without group #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesblaman merged 2 commits into from
Aug 5, 2026
Merged

Don't allow signing up to intoduction event without group #555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b0cfa
Don't allow signing up to intoduction event without group
hannesblaman Aug 4, 2026
cdd551d
Early false return for group_name None
hannesblaman Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions services/event_signup_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ def signup_to_event(event: Event_DB, user: User_DB, data: EventSignupCreate, man
):
raise HTTPException(400, detail="User already signed up to chosen event")

if (
manage_permission == False
and data.group_name is not None
and not is_group_allowed(event, user, data.group_name)
):
if manage_permission == False and not is_group_allowed(event, user, data.group_name):
raise HTTPException(status.HTTP_403_FORBIDDEN, detail="User cannot sign up with this group")

signup = EventUser_DB(user=user, user_id=user.id, event=event, event_id=event.id)
Expand Down Expand Up @@ -87,10 +83,8 @@ def update_event_signup(event: Event_DB, data: EventSignupUpdate, user_id: int,
if signup is None:
raise HTTPException(status.HTTP_404_NOT_FOUND)

if (
manage_permission == False
and data.group_name is not None
and not is_group_allowed(event, db.query(User_DB).filter(User_DB.id == user_id).one(), data.group_name)
if manage_permission == False and not is_group_allowed(
event, db.query(User_DB).filter(User_DB.id == user_id).one(), data.group_name
):
raise HTTPException(status.HTTP_403_FORBIDDEN, detail="User cannot sign up with this group")

Expand Down Expand Up @@ -137,6 +131,9 @@ def get_allowed_groups(event: Event_DB, user: User_DB):

def is_group_allowed(event: Event_DB, user: User_DB, group_name: str | None):
if event.is_nollning_event:
if group_name is None:
return False

allowed_group_types = event.mentor_group_types or list(get_args(GROUP_TYPE))
is_event_allowed = False
for gu in user.group_users:
Expand Down
Loading