Skip to content

Add group node color and description support#484

Merged
philipsens merged 3 commits into
masterfrom
feat/improved-node-grouping
May 14, 2026
Merged

Add group node color and description support#484
philipsens merged 3 commits into
masterfrom
feat/improved-node-grouping

Conversation

@stijnpotters1
Copy link
Copy Markdown
Contributor

image image

@stijnpotters1 stijnpotters1 linked an issue May 13, 2026 that may be closed by this pull request
@stijnpotters1 stijnpotters1 self-assigned this May 13, 2026
@philipsens
Copy link
Copy Markdown
Member

What will the pencil in the header of the group do?

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

What will the pencil in the header of the group do?

image

@philipsens The name of the group is automatically touched so you can edit the name quick

@philipsens
Copy link
Copy Markdown
Member

@philipsens The name of the group is automatically touched so you can edit the name quick

Ah okay, not bad, but it might be confusing because I thought it might open the sidebar, as edit button.
We might need to think if we want to do in-place editing for stuff or if we should keep it really strict for now and have all the editing in the sidebar. @Matthbo

Copy link
Copy Markdown
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine so far, I shall rereview or accept once Sergi is happy

@Matthbo
Copy link
Copy Markdown
Member

Matthbo commented May 13, 2026

@philipsens The name of the group is automatically touched so you can edit the name quick

Ah okay, not bad, but it might be confusing because I thought it might open the sidebar, as edit button. We might need to think if we want to do in-place editing for stuff or if we should keep it really strict for now and have all the editing in the sidebar. @Matthbo

I think its better to keep all the editing in the sidebar for consistency.
Having only some things inline and other things not might cause confusion

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

stijnpotters1 commented May 13, 2026

I have removed the edit possibility to make editing in the right panel more consistent

image

@stijnpotters1 stijnpotters1 force-pushed the feat/improved-node-grouping branch from 7aafa8d to 5fd01c8 Compare May 13, 2026 15:51
@stijnpotters1 stijnpotters1 requested a review from Matthbo May 13, 2026 15:52
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@philipsens philipsens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for implementing Vivy's and my feedback.

@philipsens philipsens merged commit d5f7066 into master May 14, 2026
5 checks passed
@philipsens philipsens deleted the feat/improved-node-grouping branch May 14, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node group improvements

3 participants