fix(#469): adjusted sign-up and sign-in prompt alignment#469
Conversation
|
@emmadal is attempting to deploy a commit to the React Native Reusables Team on Vercel. A member of the Team first needs to authorize it. |
emmadal
changed the title
|
Actually just had this issue too lol |
mrzachnugent
left a comment
mrzachnugent
left a comment
There was a problem hiding this comment.
@emmadal Thanks for contributing! Left a few tiny requests.
| <Text className="text-sm underline underline-offset-4">Sign up</Text> | ||
| }} | ||
| > | ||
| <Text className="text-sm underline">Sign up</Text> |
There was a problem hiding this comment.
It looks like underline-offset-4 was removed. Maybe it's because it doesn't do anything on mobile but its for the web platform. Could you please add it back? You can add the prefix web: to make it clearer.
| onPress={() => { | ||
| // TODO: Navigate to sign in screen | ||
| }}> | ||
| <Text className="text-sm underline underline-offset-4">Sign in</Text> |
There was a problem hiding this comment.
If you add the web: prefix for underline-offset-4 in the sign-in-form, could you also add it here please?
|
Hey @emmadal, do you think you'll have the time to tackle this soon? Otherwise, no worries, I can make a new PR to fix these changes. |
Hello @mrzachnugent yeah no problem i will do it today in GMT timezone |
3 participants
Description:
Fixed the alignment issue of the "Don't have an account? Sign up" text on
<SignInForm />component and "Already have an account? Sign In"<SignUpForm />componentTested Platforms:
Affected Apps/Packages: