fix: client api security improvements

[pandeymangg]

ports the recent security improvement changes made to the js-core package from PR formbricks/formbricks#7931 in formbricks to the ios sdk

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f71bbf7e-c887-4d75-937d-11e92e8ba6b2

📥 Commits

Reviewing files that changed from the base of the PR and between 7095b15 and f3a5ecb.

📒 Files selected for processing (6)

• Sources/FormbricksSDK/Manager/PresentSurveyManager.swift
• Sources/FormbricksSDK/Manager/SurveyManager.swift
• Sources/FormbricksSDK/Model/Workspace/Survey.swift
• Sources/FormbricksSDK/Model/Workspace/Surveys/Segment.swift
• Sources/FormbricksSDK/WebView/FormbricksViewModel.swift
• Tests/FormbricksSDKTests/FormbricksSDKTests.swift

💤 Files with no reviewable changes (1)

• Tests/FormbricksSDKTests/FormbricksSDKTests.swift

---

Walkthrough

This PR refactors the Segment and Survey data models for streamlined client-side representation while maintaining backward compatibility with cached payloads. The Segment model is simplified to id and hasFilters, with custom decoding that accepts legacy filters arrays. The Survey model removes its name property from the Codable payload. SurveyManager is updated to use the new segment.hasFilters contract for filtering and to reference survey.id in logging. Additionally, the survey presentation style changes from sheet to fullscreen modal with cross-dissolve transition, and the embedded WebView HTML layout is updated to use full-viewport styling instead of flexbox bottom-alignment. Tests are updated to reflect the model changes.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: client api security improvements' is partially related to the changeset—it refers to security improvements to the client API, which aligns with removing sensitive fields (name) and updating segment filtering logic for anonymous users.
Description check	✅ Passed	The description clearly explains that this PR ports security improvement changes from the js-core package (PR #7931) to the iOS SDK, which is directly related to the changeset of API model updates and filtering logic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
44.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud