Repository navigation
Conversation
… add plugin-root fallbacks (forcedotcom#370) - integration-connectivity-generate: ExternalServiceRegistration fullName must be alphanumeric (forcedotcom#364) - platform-custom-object-generate: layout required-field behavior (forcedotcom#365) and tab/App Launcher visibility (forcedotcom#369) - platform-custom-tab-generate: metadata-deployed tabs are hidden until tabSettings grants them (forcedotcom#369) - platform-sharing-owd-configure: Role access levels must be at or above OWD (forcedotcom#366) - platform-apex-generate / platform-apex-test-generate: API 67.0 record-type enforcement (forcedotcom#367) - platform-soql-query: FOR UPDATE can't be combined with ORDER BY (forcedotcom#368) - deploy, capability-search, environment-validate skills: fallback when CLAUDE_PLUGIN_ROOT is unset (forcedotcom#370)
|
Thanks for the contribution! It looks like @dmgerow is an internal user so signing the CLA is not required. However, we need to confirm this. |
ashwingadhave
added a commit
to ashwingadhave/afv-library
that referenced
this pull request
Oct 18, 2026
PR forcedotcom#371 patched both skills/ and plugins/builder/ for its gotchas, so follow that convention rather than leaving the mirror stale.
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Short doc fixes for the deploy failures reported in #364–#369, plus a fallback for skills that call plugin-root scripts on a standalone
npx skills addinstall (#370). Edits are mirrored inskills/where the skill exists there.Changes
integration-connectivity-generate: ESR file name (fullName) must be alphanumeric. Note added to the guide, the template, and the checklist.platform-custom-object-generate: layouts must setNameand other universally required fields toRequired. Trigger text now mentions page layouts.platform-sharing-owd-configure: Gotchas row covering Role access levels vs. OWD, the valid values, and theReadWriteerror.platform-apex-generate,platform-apex-test-generate: from API 67.0, DML enforces record-type availability. Includes therunAs+ permission set pattern for tests.platform-soql-query:FOR UPDATE+ORDER BYanti-pattern, with notes insoql-reference.mdandoptimization-patterns.soql.platform-custom-object-generate,platform-custom-tab-generate: a new object only appears in the App Launcher once it has a tab and visibletabSettings. Also fixes the tab skill's wrong "visible to all users by default" line.npx skills addinstall never copies #370platform-deploy-validate,platform-destructive-deploy,platform-quick-deploy: if${CLAUDE_PLUGIN_ROOT}orsf-deploy-gateis missing, classify withsf org display. The fallback fails closed and treats the org as production unless it shows a sandbox/scratch signal.platform-environment-validatefalls back to the Tools Checked commands.platform-capability-searchsays it needs the plugin and stops.Notes
For #370 I went with the guarded fallback (option 1, minus copying the scripts) so the gate script doesn't get duplicated into three skill dirs. If you'd rather mark these skills plugin-only, that's an easy swap.
Closes #364, closes #365, closes #366, closes #367, closes #368, closes #369, closes #370