Repository navigation
chore(bench): a rebuild is skipped above a rung where its library ran out of memory, so it cannot take the box down - #2045
Merged
Conversation
… out of memory, so it cannot take the box down `test_rebuild` builds in the pytest process with no isolated pass, so the memory budget had no peak of its own to project from. `Ceiling.reached` now refuses a sink-free cell above a rung where any sink of the same arm and ladder hit a memory ceiling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013mNcjLhrkQM1bzzgSKxYyh
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
test_rebuildbuilds in the pytest process, and before this PR no memory budget applied to it. NowCeiling.reachedrefuses a sink-free cell above a rung where the same library hit a memory ceiling on any sink. In published run 38393347540 that rebuild was the cell closest to a kill.Evidence: the box's own watchdog log
Job 115282561263 of run 38393347540:
memory-watchdog.shkills a case under 7,832 MB available, which is about 23.5 GB in use.highs/networkstep. Before that cell the box sat at about 1.9 GB.network/l, at 2.5 GB. So the 14.5 GB rise came from the pytest process itself.test_rebuild[network-l-linopy]. That cell has five builds of 3.67 s each, and the rise lasted 12:28:59 to 12:29:12.test_emithad refused linopy abovem: "linopy took 1.76 GB on network/m, so the next rung projects to 35.2 GB — over the 16 GB budget".So the memory budget refused the rung in the isolated pass, where it can do no harm. Then the rebuild built the same rung, unbudgeted, in the process whose death loses the whole results file. That left 7 GB of headroom.
What the next published run loses
On the committed ceilings, two rebuild rows go: linopy at
network/l, and the matchinggurobi-file row if rebuilds run there. Rebuilds run only with--builds 5on thehighsfile, so in practice that is linopynetwork/l. Pyomo atdispatch/lalready stops on its time ceiling. The page's first-vs-steady table then shows that cell as over budget.Mutation table, and gates
if sink: return None: a sink keeps its own ceiling (conftest.py:371-372)tools.mutate)conftest.py:374-377)tools.mutate)and above: the rung the ceiling was recorded at still runsthe-rung-that-was-measuredfailed)tools.mutateran withCI=1, because under xdist every worker contends for the machine lock inpytest_sessionstartand nothing runs.ruff check .,ruff format --check .,pyrefly check, all ofbench/test_harness.py(451 passed, 44 skipped), andtests/test_assertions.pyandtests/test_architecture.py. These ran throughuvrather than pixi, because pixi is not installed here. The diff does not touchsrc/.COPIES_HELD = 2says the timed rounds and the isolated child hold the model at the same time. pytest-benchmem joins the child before the timed rounds start, so they never do. Onnetwork/mthe box sat about 3.5 GB above idle against a 1.76 GB child, so the factor of two held in practice, and I left it.ccx33with 31 GB.🤖 Generated with Claude Code
https://claude.ai/code/session_013mNcjLhrkQM1bzzgSKxYyh
Generated by Claude Code