Merged
Conversation
Contributor
|
Claude finished @ZanCorDX's task in 40s —— View job Review of PR #914
Changes look good. The 10x increase to One minor issue found — typo in the comment ("slow" → "slot") — posted as an inline comment. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| /// Channel size for the order journal. Orders are small and arrive frequently. | ||
| const ORDER_JOURNAL_CHANNEL_SIZE: usize = 10 * 1024; | ||
| /// A busy slow can have 30K-40K orders. 100K should be more than enough. |
Contributor
There was a problem hiding this comment.
Nit: typo — "slow" → "slot".
Suggested change
| /// A busy slow can have 30K-40K orders. 100K should be more than enough. | |
| /// A busy slot can have 30K-40K orders. 100K should be more than enough. |
dvush
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Increased ORDER_JOURNAL_CHANNEL_SIZE x 10 since it would get filled in busy slots.
Removed 2 unused constants.
✅ I have completed the following steps:
make lintmake test