Migrate from mypy to pyright and clean up type annotations#895
Draft
Migrate from mypy to pyright and clean up type annotations#895
mypy to pyright and clean up type annotations#895Conversation
mypy to pyright and clean up type annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced mypy with pyright for type checking. While migrating, we stumbled across a handful of actual bugs and misconceptions hiding behind
# type: ignorecomments — so we fixed those instead of carrying them over.Notable fixes along the way:
base_parser.py,regex.py, andparser/data.pywere tightenedJSONFileand its subclass dropped@dataclassin favor of explicit__init__, resolving a field type invariance issue cleanlyAlmost all
# type: ignorecomments are gone. The two that remain are intentional: one suppresses a third-party stubs incompatibility (warcio/urllib3), the other marks an intentionally invalid API call in a test.Update: Maybe heading for
ty[1] right away is the better choice here.