Repository navigation
fix(solver): preserve incremental queries, theory lemmas and bit widths - #563
Merged
Merged
Conversation
sjkim1127
enabled auto-merge
October 19, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Split the Solver work from mixed PR #562 so its unresolved normalization finding does not block independent Solver correctness fixes. No normalization, loader, script, signature, CLI/schema or production dependency changes are included.
Closes #532. Closes #427. Closes #428. Closes #545. Closes #561.
Closes #337. Closes #393. Closes #365. Closes #382.
Changes
Existing contracts retained
Scalar widths remain 1..=64. Wider/invalid scalar operations produce Unknown and no scalar model; this PR does not implement arbitrary-precision values. Signed operand width mismatches already abstained on main; they continue to return Unknown rather than guessing sign extension. Some AIG extract/constant/array guards were already present on main and are verified by the new issue regressions. LBD was previously computed after backtracking, but current backtracking retains level metadata; the reproduced #382 defect was glue eviction, not a demonstrated LBD numeric mismatch.
Array read/store axioms and memory CEGAR issue #295 remain separate; this PR does not claim complete array theory support or close that issue.
Evidence
New regressions failed before their fixes: mixed-width subtraction (even 0:2 - 0:1), assertion cursor, constant queries, nested array lowering/model extraction, assumptions lost by theory units, missed theory propagation, fresh multi-literal theory variables, sticky empty/root theory conflicts, and glue retention. Retained logs are under Fission benchmark/artifacts/pr-issue-triage/2026-10-19/.
The optional external SMT process oracle remains skipped. No decompiler-quality, execution-parity, speed or ranking claim is made. Remote CI must pass on the submitted HEAD before merging; #562 and its normalization issues remain open.