-
Notifications
You must be signed in to change notification settings - Fork 145
feat(fcm): Enable fid and deprecate token for Send API
#525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yvonnep165
wants to merge
13
commits into
main
Choose a base branch
from
yp-add-fid-arg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3345cd0
Add fid and deprecate token for Message and add fids and deprecate to…
yvonnep165 c210002
Add integration tests
yvonnep165 1c437f4
Update error code documentation
yvonnep165 6bd7842
Add pragma warning disable CS0618 wrappers in snippets
yvonnep165 8c1f06d
Fix error message formatting
yvonnep165 2044811
Update documentation comments for both SendEachForMulticastAsync and …
yvonnep165 e113863
Replace token payload with the fid payload in firebaseMessagingClient…
yvonnep165 6e85eec
Add code snippet to show the new usage with Fids
yvonnep165 a52c80d
Add token error tests back in FirebaseMessagingClientTest
yvonnep165 1eccd74
Remove trailing comma for pragma warning disable CS0618
yvonnep165 3e29acf
Update Fid to all capital
yvonnep165 634a747
Update Fids to be all capital
yvonnep165 bb66a4e
Update Fids to FIDs
yvonnep165 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add extend the code snippet to show the new usage with Fids?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Code snippets for the new usage with Fids are added.