Skip to content

chore: strip comments from tsconfigs for Snyk JSON parsing#207

Merged
JuroUhlar merged 2 commits into
mainfrom
chore/snyk-strict-json-tsconfigs
Jul 21, 2026
Merged

chore: strip comments from tsconfigs for Snyk JSON parsing#207
JuroUhlar merged 2 commits into
mainfrom
chore/snyk-strict-json-tsconfigs

Conversation

@JuroUhlar

Copy link
Copy Markdown
Collaborator
  • Remove JSON comments from tsconfig files so Snyk can parse them as strict JSON
  • Keep only active options in the Preact example tsconfig (drop the commented template)

Snyk import was failing on these files with "Unable to parse json file".

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 82.43% 122/148
🟡 Branches 68.97% 60/87
🟢 Functions 80.85% 38/47
🟢 Lines 82.52% 118/143

Test suite run success

23 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from e605ed0

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 82.43 68.96 80.85 82.51
🟢  src 88.52 74.07 83.33 88.33
🟢   detect-env.ts 90 83.33 100 90 15,87
🟢   env.ts 100 100 100 100
🟢   env.types.ts 83.33 0 50 83.33 14
🟡   ...nt-context.ts 75 100 0 75 8
🟡   get-env.ts 60 0 100 60 8-9
🟢   ssr.ts 100 100 100 100
🟢   ...sitor-data.ts 95.65 100 80 95.65 102
🟢  src/components 91.66 58.33 91.66 91.17
🟢   ...-provider.tsx 90.32 54.54 90.9 89.65 47,52,85
🟢   ...vironment.tsx 100 100 100 100
🟡  src/utils 68.62 72.22 70.58 69.38
🟡   ...is-defined.ts 50 75 100 50 3
🟢   ...-cache-key.ts 80.76 83.33 85.71 84 5,10,43,52
🟡   to-error.ts 66.66 50 100 66.66 6
🟢   ...mise-store.ts 100 100 100 100
🔴   wait-until.ts 0 0 0 0 8-19

@JuroUhlar

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

TheUnderScorer
TheUnderScorer previously approved these changes Jul 21, 2026

Copilot AI commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved. The only conflict was in examples/preact/tsconfig.json — merged main's updated values ("target": "ES2015", "moduleResolution": "bundler") with this PR's comment-stripped format. Commit: e605ed0.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/react@3.1.0

Minor Changes

  • Add support for React 19 and Next.js 16. The react peer range now accepts >=18 <20. (5307b3b)

Patch Changes

  • Bump @fingerprint/agent dependency to ^4.1.2 and drop the fast-deep-equal runtime dependency in favor of an internal cache-key comparison. (87b776f)

@JuroUhlar
JuroUhlar requested a review from TheUnderScorer July 21, 2026 08:48
@JuroUhlar
JuroUhlar merged commit c587a55 into main Jul 21, 2026
24 checks passed
@JuroUhlar
JuroUhlar deleted the chore/snyk-strict-json-tsconfigs branch July 21, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants