test: disallow network MaxBlobSize and Piri DefaultMaxPaddedSize drift - #104
Merged
alanshaw merged 3 commits intoSep 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a narrowly-scoped test asserting an important invariant, with a straightforward dependency bump to support it.
Pull request overview
Adds a regression test in the PDP piece sizing package to ensure the network sharding raw-size constant from libforge remains aligned with Piri’s default padded-size ceiling, preventing accidental drift between the two projects.
Changes:
- Import and assert
libforge’sblob.MaxBlobSizepads exactly topiecesize.DefaultMaxPaddedSize, and thatMaxBlobSize+1spills to the next padded level. - Bump
github.com/fil-forge/libforgeto a newer pseudo-version to pick up the constant referenced by the new test. - Update
go.sumaccordingly (including an indirectgolang.org/x/expversion change).
File summaries
| File | Description |
|---|---|
| pkg/pdp/piecesize/piecesize_test.go | Adds a cross-repo drift guard by asserting libforge’s raw sharding cap maps exactly onto Piri’s default padded piece ceiling. |
| go.mod | Updates the libforge dependency (and records an indirect x/exp update). |
| go.sum | Updates module checksums to match the dependency bumps. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bajtos
approved these changes
Sep 2, 2026
…default-max-blob-drift
alanshaw
deleted the
ash/test/disallow-network-max-blob-and-piri-default-max-blob-drift
branch
September 4, 2026 21:29
fil-forge-bot Bot
added a commit
to fil-forge/infra-nodes
that referenced
this pull request
Sep 4, 2026
Published from fil-forge/piri#104 - Digest: `sha256:3ad70523d939e40da14eace730a633cc5e5e00a7a5d5a2e9136573e6928f5bfc` - Commit: fil-forge/piri@506d00a - Publish run: https://github.com/fil-forge/piri/actions/runs/33921348878 Merging rewrites [`nodes/dev/apps/versions.env`](https://github.com/fil-forge/infra-nodes/blob/main/nodes/dev/apps/versions.env) and queues the image. The node picks it up on its next reconcile pass, waits for a safe proving window and then restarts the service, so the deploy happens well after this merges. Co-authored-by: fil-forge-bot[bot] <318653112+fil-forge-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates assertions to prevent these two constants drifting.
Mentioned by Claude which I agree with:
Depends on:
MaxBlobSizewith PiriDefaultMaxPaddedSizelibforge#65refs #49