refactor: use the OpenBao API client - #51
Conversation
Replace github.com/hashicorp/vault-client-go with github.com/openbao/openbao/api/v2, the client OpenBao ships and keeps in step with the server we run. The KV v2 calls move to client.KVv2(mount) (Get/Put/DeleteMetadata) and not-found now comes from api.ErrSecretNotFound, since the new client turns a 404 into that sentinel instead of surfacing the status. The 403 that drives the AppRole re-login is matched on api.ResponseError. Secret paths and the base64 "value" field are unchanged, so stored key material stays readable and no migration is needed. Assisted-by: Claude:claude-opus-5[1m] Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
I asked Claude about the itest failures: ingot crash-loops on startup and compose gives up on it. The @ash can you PTAL? |
Replace github.com/hashicorp/vault-client-go with github.com/openbao/openbao/api/v2, the client OpenBao ships and keeps in step with the server we run.
The KV v2 calls move to
client.KVv2(mount)(Get/Put/DeleteMetadata) and not-found now comes fromapi.ErrSecretNotFound, since the new client turns a 404 into that sentinel instead of surfacing the status. The 403 that drives the AppRole re-login is matched onapi.ResponseError.Secret paths and the base64 "value" field are unchanged, so stored key material stays readable and no migration is needed.
Close FIL-1107