Harden the test suite - #956
Merged
Merged
Conversation
felladrin
force-pushed
the
fix/harden-test-suite
branch
from
August 6, 2026 12:19
762316b to
b16f23a
Compare
- Fix unsubscribe bug: repair both predecessor and successor pointers on removal so later unsubscribe never reads a stale reference. Keeps both subscribe and unsubscribe O(1). - Replace weak "unsubscribe twice" test with two stronger tests: one that verifies double-unsubscribe doesn't clobber intervening subscriptions, and one that catches the adjacent-unsubscribe bug - Add fail-fast: false to CI matrix so all Node versions run - Remove dead fileURLToPath import and stale globals mapping from rollup config - Remove inert ../main and ../immer from react externals - Simplify smoke test build hook (remove unnecessary try/catch) Fixes #934
felladrin
force-pushed
the
fix/harden-test-suite
branch
from
August 6, 2026 12:24
b16f23a to
e7b0343
Compare
jsdom@30 requires Node 22+, so Node 20 already fails at npm ci (prepare script triggers rollup which can't load .ts config on Node 20). Node 20 reached EOL in April 2025 anyway. Fixes CI failure on PR #956.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
New tests (4):
node = 0guard)get()before anything is published on a store without initial valueSmoke test (6 tests):
npm run buildand imports every entry point from both ESM and CJScreate-pubsub/immerfails on Node ESM withERR_UNSUPPORTED_DIR_IMPORT#927 (directory import in immer ESM bundle)CI improvements:
lts/*