Only fetch a release URL if the requested version is not cached - #1409
Closed
alterNERDtive wants to merge 1 commit into
Closed
alterNERDtive wants to merge 1 commit into
alterNERDtive wants to merge 1 commit into
Conversation
This was referenced Apr 25, 2026
6 tasks
Owner
|
Superseded by #1527 (now merged), which builds directly on your analysis and carries your |
pull Bot
pushed a commit
to Patlukat/foundryvtt-docker
that referenced
this pull request
Sep 20, 2026
…uest Every start-up authenticated with foundryvtt.com and fetched a presigned release URL, even when the requested release zip was already cached and licensing was settled. Simultaneous container start-ups sharing a cache immediately ran into rate limiting (felddy#1399), and a foundryvtt.com outage could fail a start-up that needed nothing from the account. Compute the cache paths first, then authenticate only when the release is missing from the cache or a license still needs to be fetched, and fetch a release URL only when a download is actually required. The FOUNDRY_RELEASE_URL path is unchanged, including its --time-cond freshness check; release zips are immutable per build, so a cached zip is trusted as-is. Based on alterNERDtive's felddy#1409. Co-authored-by: alterNERDtive <nerd@alternerd.tv> Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
We do not have to fetch a release URL if the zip file for the requested Foundry version has already been cached (see #1399).
💭 Motivation and context
Currently, we are always fetching the release URL, no matter if we are actually going to use it or not. With multiple containers starting up at the same time, you immediately run into rate limiting on Foundry’s side.
🧪 Testing
I haven’t tested this yet, just getting the drafts done before I have to head out.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist