fix: enroll with the open mode the course offers instead of hardcoded audit - #75
Open
ccantillo wants to merge 1 commit into
Open
fix: enroll with the open mode the course offers instead of hardcoded audit#75ccantillo wants to merge 1 commit into
ccantillo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "Start Course" enrollment failure — openedx-corporate
Problem
Clicking Start Course on a catalog course card showed "Enrollment failed"
for users not yet enrolled in the course. The card already calls
POST /partner_catalog/api/v1/catalogs/{id}/courses/{course_id}/enroll/, butfor open courses the backend always requested the LMS enrollment with a
hardcoded
auditmode. NAU courses are configured withhonorinstead, sothe LMS raised
CourseModeNotFoundError(an unhandled 500).This is also why the button "started working" after enrolling through the
course page: the learning MFE enrolls with the course's default mode, and once
any LMS enrollment exists the failing
add_enrollmentcall is skipped.What changed
partner_catalog/services/platform_enrollment.pyensure_edx_platform_enrollmentnow resolves open-access targets to theopen mode the course actually offers (
auditpreferred,honorfallback)instead of passing
auditblindly.unnecessary
update_enrollmentcall.latent crash in
downgrade_to_audit(unenrollment) for honor-mode courses.partner_catalog/services/enrollments.py_sync_lms_for_catalog_accessreports the effective mode returned by thesync instead of assuming the hardcoded target, so the API response's
lms_enrollment_modeis accurate.