ci: pin foundry to v1.2.3 in Dockerfile.foundry - #494
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Pins Foundry inside Dockerfile.foundry to a specific version to avoid the deployer image using a moving stable toolchain that can diverge from CI/compiler expectations.
Changes:
- Replaces
foundryup --install stablewithfoundryup --install v1.2.3. - Adds an in-file rationale comment describing the intended consistency goal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
`foundryup --install stable` is a moving target and currently resolves to v1.7.1, while CI installs v1.2.3 on the host via foundry-rs/foundry-toolchain. The build-image job was therefore compiling and deploying the same sources with a different compiler than the test, coverage, and halmos jobs. v1.2.3 is what was stable when the tree was last touched (main's last commit is 2025-06-17; v1.2.3 shipped 2025-06-08, v1.3.0 on 2025-07-31), and it is the only version that reproduces the checked-in formatting -- `forge fmt --check` passes with zero diffs under it and fails under newer releases.
topocount
force-pushed
the
kjs/neyn-13118-pin-foundry-in-dockerfile
branch
from
August 5, 2026 21:58
d97e7c5 to
1ba8f8d
Compare
|
Coverage after merging kjs/neyn-13118-pin-foundry-in-dockerfile into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile.foundryinstalls Foundry withfoundryup --install stable, which is a moving target. It currently resolves to v1.7.1, while CI installs v1.2.3 on the host viafoundry-rs/foundry-toolchain. Thebuild-imagejob has therefore been compiling and deploying the same sources with a different compiler than thetest,coverage, andhalmosjobs.Why v1.2.3
main's last commit is 2025-06-17. Foundry v1.2.3 shipped 2025-06-08 and v1.3.0 on 2025-07-31, so v1.2.3 is what was stable when the tree was last formatted. It is also the only version that reproduces the checked-in formatting:forge fmt --checkpasses with zero diffs onmainunder v1.2.3 and fails under newer releases.This closes a skew rather than introducing one — the host is already pinned to v1.2.3, and this makes the deployer image agree with it. Bump both together.
Verification
The image builds and reports
forge/cast/anvil/chiselall at1.2.3-dev (a813a2cee7 2025-06-08).The full
docker composestack could not be exercised locally:.env.localshipsETH_MAINNET_RPC_URL/OP_MAINNET_RPC_URL/BASE_MAINNET_RPC_URLblank and CI injects them as secrets, so the anvil services exit witha value is required for '--fork-url <URL>'. That is an environment gap rather than a defect in the pin — the fork URL is required regardless of Foundry version — sobuild-imageon this PR is the real check.🤖 Generated with Claude Code
PR-Codex overview
This PR focuses on updating the
Dockerfile.foundryto pin the Foundry version tov1.2.3instead of tracking thestableversion, ensuring consistency between the deployer image and CI jobs.Detailed summary
stableversion of Foundry.v1.2.3to maintain consistency.