Skip to content

fix(plugins/k8saudit-aks): skip non-JSON records before parsing #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raajheshkannaa wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −4
Open

fix(plugins/k8saudit-aks): skip non-JSON records before parsing #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b168a49
fix(plugins/k8saudit-aks): skip non-JSON records before parsing
raajheshkannaa May 7, 2026
7b23a83
fix(plugins/k8saudit-aks): use fastjson.ValidateBytes for JSON guard
raajheshkannaa May 7, 2026
a5cb0cf
fix(plugins/k8saudit-aks): inline fastjson.ValidateBytes per review
raajheshkannaa May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/k8saudit-aks/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ require (
github.com/falcosecurity/plugins/plugins/k8saudit v0.17.0
github.com/falcosecurity/plugins/shared/go/azure/eventhub v0.0.0-20250617140945-5d23e77c8bbd
github.com/invopop/jsonschema v0.14.0
github.com/valyala/fastjson v1.6.4
golang.org/x/time v0.15.0
)

Expand All @@ -22,7 +23,6 @@ require (
github.com/fsnotify/fsnotify v1.9.0 // indirect
github.com/iancoleman/orderedmap v0.3.0 // indirect
github.com/pb33f/ordered-map/v2 v2.3.1 // indirect
github.com/valyala/fastjson v1.6.4 // indirect
go.yaml.in/yaml/v4 v4.0.0-rc.2 // indirect
golang.org/x/net v0.47.0 // indirect
golang.org/x/sys v0.38.0 // indirect
Expand Down
2 changes: 0 additions & 2 deletions plugins/k8saudit-aks/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/falcosecurity/plugin-sdk-go v0.8.3 h1:KsX7qt83dzC57qcNpZKaBrCjTXqpXgvxDcEXs6Z5sHI=
github.com/falcosecurity/plugin-sdk-go v0.8.3/go.mod h1:gEgxjvuopv5VF4wc8s0EHnmT9qrIKBtcJVBnRlEPU1A=
github.com/falcosecurity/plugins/plugins/k8saudit v0.16.1 h1:K7D2dOkSB0Sg0grN7Nt++15MoKzRdMSO8dzq7OdEgXo=
github.com/falcosecurity/plugins/plugins/k8saudit v0.16.1/go.mod h1:aXuvIMirc59LeXnh1m7MJbWpmUUE+r19FUjkYTPhHA0=
github.com/falcosecurity/plugins/plugins/k8saudit v0.17.0 h1:YmIgYN7USDi8OWcjSdegW/aJbdJ9ODMhAPWJduRfyVA=
github.com/falcosecurity/plugins/plugins/k8saudit v0.17.0/go.mod h1:0IV2vwoFgbM6e5P7rG9E9WQPAvMJDm6sj2OVdifbQKo=
github.com/fortytw2/leaktest v1.3.0 h1:u8491cBMTQ8ft8aeV+adlcytMZylmA5nnwwkRZjI8vw=
Expand Down
12 changes: 11 additions & 1 deletion plugins/k8saudit-aks/pkg/k8sauditaks/k8sauditaks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import (
"github.com/falcosecurity/plugins/plugins/k8saudit/pkg/k8saudit"
falcoeventhub "github.com/falcosecurity/plugins/shared/go/azure/eventhub"
"github.com/invopop/jsonschema"
"github.com/valyala/fastjson"
"golang.org/x/time/rate"
)

Expand Down Expand Up @@ -197,7 +198,16 @@ func (p *Plugin) Open(_ string) (source.Instance, error) {
if !ok {
return
}
values, err := p.Plugin.ParseAuditEventsPayload([]byte(i.Properties.Log))
// AKS diagnostic settings can route categories other than
// `kube-audit` to the same EventHub (kube-apiserver, kube-controller-manager,
// cluster-autoscaler, etc.). Those records carry klog text in
// properties.log instead of a JSON audit event. Pre-validate so
// the parser does not spam "cannot parse JSON" errors. See issue #1145.
logBytes := []byte(i.Properties.Log)
if fastjson.ValidateBytes(logBytes) != nil {
continue
}
values, err := p.Plugin.ParseAuditEventsPayload(logBytes)
if err != nil {
p.Logger.Println(err)
continue
Expand Down
Loading