Repository navigation
Conversation
Contributor
Author
|
Superseded by #79 at the exact same commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to merged #14.
Summary
Lake TOML requirement and every Lake-consumed manifest/override field
presence, exact-case aliases, root discovery, and
.lakegeneration checks;retry boundedly and fail if the project changes
regular descriptor before reading, cap bytes, and revalidate descriptor,
pathname, and content afterward
Autoform scaffold detection
This closes three reproduced false-safety gaps from the merged implementation:
a malformed Lake field could still report
supported; sequential reads couldsynthesize a supported pair that never existed; and a regular-file-to-FIFO swap
could be opened after the pathname check.
Validation
tests/test_project_inspect.py: 169 passed on Python 3.10tests/test_project_inspect.py: 169 passed on Python 3.13git diff --check: passedmake check-example: passedproject inspect|versions: passedformal-math,hatcher-at, andzeta7-irrational: correct unlistedcurrent pairs
The unrelated full-suite subprocess tail and shared-
.venvrace were not usedas evidence; their affected paths are outside this three-file diff.