Skip to content

Harden project compatibility inspection snapshots - #78

Closed
Deicyde wants to merge 1 commit into
facebookresearch:mainfrom
VivienCabannes:codex/fix-project-inspection-snapshot
Closed

Deicyde wants to merge 1 commit into
facebookresearch:mainfrom
VivienCabannes:codex/fix-project-inspection-snapshot

Conversation

@Deicyde

@Deicyde Deicyde commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Follow-up to merged #14.

Summary

  • certify a Lean/Mathlib release pair only after strictly decoding the active
    Lake TOML requirement and every Lake-consumed manifest/override field
  • read the small decision-file set as one coherent bounded snapshot, including
    presence, exact-case aliases, root discovery, and .lake generation checks;
    retry boundedly and fail if the project changes
  • open decision files nonblocking and no-follow where supported, require a
    regular descriptor before reading, cap bytes, and revalidate descriptor,
    pathname, and content afterward
  • preserve Add bounded Lean project inspection #14's slim public JSON/model surface and exact-only optional
    Autoform scaffold detection

This closes three reproduced false-safety gaps from the merged implementation:
a malformed Lake field could still report supported; sequential reads could
synthesize a supported pair that never existed; and a regular-file-to-FIFO swap
could be opened after the pathname check.

Validation

  • tests/test_project_inspect.py: 169 passed on Python 3.10
  • tests/test_project_inspect.py: 169 passed on Python 3.13
  • combined project/plugin/CLI focused gate: passed
  • full Ruff and git diff --check: passed
  • make check-example: passed
  • wheel build + isolated installed project inspect|versions: passed
  • real formal-math, hatcher-at, and zeta7-irrational: correct unlisted
    current pairs
  • real Lake 4.32.2 catalog sample: supported
  • independent Lake-semantics and snapshot-race audits: approved

The unrelated full-suite subprocess tail and shared-.venv race were not used
as evidence; their affected paths are outside this three-file diff.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 3, 2026
@Deicyde

Deicyde commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #79 at the exact same commit 2d083e0. Development has been moved to a branch in facebookresearch/autoform-bot; the fork branch is being removed.

@Deicyde Deicyde closed this Oct 3, 2026
@Deicyde
Deicyde deleted the codex/fix-project-inspection-snapshot branch October 3, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant