You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Moved from #35. Its head branch lived on VivienCabannes/autoform-bot, which is being deleted, so this PR uses the same-named branch in facebookresearch/autoform-bot (same commits, head aa789e4). Earlier review and discussion are on #35.
Summary
render from bounded immutable blueprint and Lean snapshots into a frozen file plan
materialize through retained directory descriptors with no-follow, exclusive writes
install new sites atomically and replace owned sites with one verified exchange
fsync staged files and every newly created output-parent generation
track exact publication inventories for safe cleanup and truthful recovery reporting
reject source, stage, destination, and parent-generation changes without rollback after commit begins
Depends on #28. The reviewable change is commit aa789e4; earlier commits belong to the dependency stack.
#73 should not be refreshed or merged as-is. Its snapshot prerequisites landed via #95, but the atomic output transaction remains genuinely unmerged; current render_site still deletes/writes the live destination in place.
Rebuild from repaired local candidate dc80ef23, not stale head aa789e4. Preserve current open/conditional status rendering, container behavior, dashboard Host/Origin guards, dual path/article claim targets, runtime fields, and #95 snapshot APIs when resolving its four current-main conflict files. #145 is complementary: verification should gate Pages first, while transactional render protects the generated site tree.
One human-visible decision is required: dc80ef23 intentionally makes render unavailable outside Linux renameat2 / macOS renameatx_np, including Windows, whereas main currently renders on Windows. Either approve/document that capability boundary or design a safe portable transaction. Then run current CI plus recovery/fault and workflow integration tests, open the clean replacement, and close this stale 8K-line branch as superseded. Existing green checks do not validate the repaired/current-base code.
Superseded by #165, rebuilt from repaired dc80ef23 on current main with all current status/container/dashboard/claim semantics preserved. The replacement adds explicit filesystem capability probing, Windows fail-before-write behavior, process-exit recovery, exact recovery paths, serialized dashboard claim reads, and snapshot-policy ABA protection; independent review is clean and 434 touched-surface tests pass.
Closing this stale pre-#95 branch so review happens on the focused current-base implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaiting authorReview is complete and author action is requiredCLA SignedThis label is managed by the Meta Open Source bot.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved from #35. Its head branch lived on VivienCabannes/autoform-bot, which is being deleted, so this PR uses the same-named branch in facebookresearch/autoform-bot (same commits, head aa789e4). Earlier review and discussion are on #35.
Summary
Depends on #28. The reviewable change is commit
aa789e4; earlier commits belong to the dependency stack.Validation
make lintmake check-examplegit diff --check